-
Notifications
You must be signed in to change notification settings - Fork 52
fix(devnet): Docker images #2996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Alenar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a comment.
Another point: did you forgot the mithril-relay ?
I adapted the Makefile for the relay as well 👍 |
73d72ae to
7a9fd89
Compare
* mithril-aggregator from `0.8.20` to `0.8.21` * mithril-client-cli from `0.12.38` to `0.12.39` * mithril-relay from `0.2.1` to `0.2.2` * mithril-signer from `0.3.13` to `0.3.14` * mithril-test-lab/mithril-devnet/VERSION from `0.4.22` to `0.4.23`
turmelclem
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
7a9fd89 to
07cb965
Compare
Content
This PR includes improvements and fixes for the devnet:
build-citarget to theMakefileformithril-aggregator,mithril-signer, andmithril-client-cli, enabling architecture-aware builds for CI and improving compatibility with different Linux architectures. The correspondingdocker-build-citargets now depend onbuild-ciinstead of the regular build..ciDockerfiles for all components to consolidate and streamline package installation by combining all required packages (includingadduser) into a singleapt-getcommand fordebian:13-slim.DMQ_NODE_SOCKET_PATHenvironment variable to aggregator and signer Docker imagesCertificateEpochGapvariant in the Rust service interface to clarify the required actions for leader and follower aggregators during an epoch gap.Pre-submit checklist