Skip to content

Conversation

@jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Feb 10, 2026

Content

This PR includes improvements and fixes for the devnet:

  • Added a build-ci target to the Makefile for mithril-aggregator, mithril-signer, and mithril-client-cli, enabling architecture-aware builds for CI and improving compatibility with different Linux architectures. The corresponding docker-build-ci targets now depend on build-ci instead of the regular build.
  • Updated the .ci Dockerfiles for all components to consolidate and streamline package installation by combining all required packages (including adduser) into a single apt-get command for debian:13-slim.
  • Added missing DMQ_NODE_SOCKET_PATH environment variable to aggregator and signer Docker images
  • Fixed the startup order in the devnet run script to correctly start Cardano nodes before DMQ nodes.
  • Improved the error message for the CertificateEpochGap variant in the Rust service interface to clarify the required actions for leader and follower aggregators during an epoch gap.

Pre-submit checklist

  • Branch
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@jpraynaud jpraynaud self-assigned this Feb 10, 2026
@github-actions
Copy link

github-actions bot commented Feb 10, 2026

Test Results

    5 files  ±0    172 suites  ±0   38m 26s ⏱️ -5s
2 513 tests ±0  2 513 ✅ ±0  0 💤 ±0  0 ❌ ±0 
7 783 runs  ±0  7 783 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 07cb965. ± Comparison against base commit df080cd.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@Alenar Alenar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a comment.

Another point: did you forgot the mithril-relay ?

@jpraynaud
Copy link
Member Author

Another point: did you forgot the mithril-relay ?

I adapted the Makefile for the relay as well 👍

* mithril-aggregator from `0.8.20` to `0.8.21`
* mithril-client-cli from `0.12.38` to `0.12.39`
* mithril-relay from `0.2.1` to `0.2.2`
* mithril-signer from `0.3.13` to `0.3.14`
* mithril-test-lab/mithril-devnet/VERSION from `0.4.22` to `0.4.23`
Copy link
Collaborator

@turmelclem turmelclem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jpraynaud jpraynaud force-pushed the jpraynaud/fix-devnet branch from 7a9fd89 to 07cb965 Compare February 10, 2026 16:55
@jpraynaud jpraynaud merged commit c52f287 into main Feb 10, 2026
98 of 100 checks passed
@jpraynaud jpraynaud deleted the jpraynaud/fix-devnet branch February 10, 2026 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants