Skip to content

Conversation

@kbennett2000
Copy link
Contributor

Made documentation updates to the FAQ, Resources, and How It Works pages.

@kbennett2000 kbennett2000 added the documentation Improvements or additions to documentation label Mar 12, 2025
@kbennett2000 kbennett2000 self-assigned this Mar 12, 2025
@will-break-it
Copy link
Contributor

Can you remove the package-lock.json files - they shouldn't be committed. Perhaps we can add them to the .gitignore

Copy link
Contributor

@will-break-it will-break-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the unneeded lock files, looks good!

@Quantumplation
Copy link
Contributor

Generally it's good practice to include package-lock.json files in your commits, isn't it? that allows you to re-install the exact set of dependencies that a commit was made with.

Remove package-lock.json from PR
Remove yarn.lock from PR
@kbennett2000
Copy link
Contributor Author

Can you remove the package-lock.json files - they shouldn't be committed. Perhaps we can add them to the .gitignore

They're gone! I'll add those files into .gitignore on the next PR

@kbennett2000 kbennett2000 merged commit 8437d9a into main Mar 12, 2025
2 of 3 checks passed
@kbennett2000 kbennett2000 deleted the kb-documentation-updates-2025-03 branch March 12, 2025 15:46
@will-break-it
Copy link
Contributor

will-break-it commented Mar 14, 2025

Generally it's good practice to include package-lock.json files in your commits, isn't it? that allows you to re-install the exact set of dependencies that a commit was made with.

That's correct @Quantumplation generally, but if you take look at the directory structure a package-lock.json in the root was added, probably because npm install was ran instead of the inside site folder.
And in addition, there was a yarn.lock file implying that yarn is used not npm

@Quantumplation
Copy link
Contributor

Ah right lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants