Skip to content

Conversation

@nfrisby
Copy link
Contributor

@nfrisby nfrisby commented Aug 27, 2025

For this to be true ...

The certified_eb bit enables syncing nodes to predict the total size of valid responses to their requests for batches of EBs certified on the historical chain.

... the announced_eb_size field needs to be the size of the txs, not the size of the tx references. Syncing nodes need to download all of the txs --- there's no reason they'd already have a subset of them. And they can reconstruct the tx references from the list of txs they receive.

The MsgLeiosBlockOffer does claim a byte size for the list of references, and the peer can disconnect if the peer sends an EB body with a different size.


This resulting scheme is a natural match for the fact that the reason an EB body contains references to txs instead of the txs themselves is merely an optimization.

@nfrisby nfrisby requested a review from will-break-it August 27, 2025 12:54
@nfrisby nfrisby requested a review from ch1bo August 27, 2025 12:54
@github-actions
Copy link
Contributor

⚠️ CIP formatting needed - The CIP document needs formatting (TOC, figures/tables, markdown). Please run ./scripts/format-cip.sh docs/cip/README.md locally and commit the changes.

@nfrisby
Copy link
Contributor Author

nfrisby commented Aug 27, 2025

An alternative to this PR would be to leave announced_eb_size alone and add another header field announced_eb_tx_size alongside it.

Copy link
Member

@ch1bo ch1bo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks.

We should make changes to the CIP via the cardano-scaling/CIPs:leios branch, like I did with this PR

@nfrisby
Copy link
Contributor Author

nfrisby commented Aug 28, 2025

I migrated it here cardano-scaling/CIPs#13

@nfrisby nfrisby closed this Aug 28, 2025
@will-break-it will-break-it deleted the nfrisby/cip-size-fixup branch September 12, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants