add native stake to d-param #1072
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jankun4
force-pushed
the
native-stake-d-param
branch
6 times, most recently
from
9447854 to
775efeb
Compare
AmbientTea
requested changes
Oct 30, 2025
Contributor
AmbientTea
left a comment
AmbientTea
left a comment
There was a problem hiding this comment.
We need to make the d-param and selection pallet versioned for this to be backwards compatible. Let me know if you need support with this.
Comment on lines
54
to
+70
| impl From<DParamDatum> for sidechain_domain::DParameter { | ||
| fn from(datum: DParamDatum) -> Self { | ||
| match datum { | ||
| DParamDatum::V0 { num_permissioned_candidates, num_registered_candidates } => { | ||
| Self { num_permissioned_candidates, num_registered_candidates } | ||
| DParamDatum::V0 { num_permissioned_candidates, num_registered_candidates } => Self { | ||
| num_permissioned_candidates, | ||
| num_registered_candidates, | ||
| num_native_stake_candidates: 0, | ||
| }, | ||
| DParamDatum::V1 { | ||
| num_permissioned_candidates, | ||
| num_registered_candidates, | ||
| num_native_stake_candidates, | ||
| } => Self { | ||
| num_permissioned_candidates, | ||
| num_registered_candidates, | ||
| num_native_stake_candidates, |
Contributor
There was a problem hiding this comment.
Have you tested upgrading a chain to this version? I'm pretty sure this will break existing chains that use the current 2-value d-param. We need to introduce DParameterV2, bump the selection pallet's version, and modify the Ariadne IDP to be version-aware so it knows what schema of inputs it should provide to the pallet.
jankun4
force-pushed
the
native-stake-d-param
branch
4 times, most recently
from
4cc909e to
f1e27f1
Compare
jankun4
force-pushed
the
native-stake-d-param
branch
from
f1e27f1 to
b8eccce
Compare
jankun4
force-pushed
the
native-stake-d-param
branch
from
b8eccce to
c4b069f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds third value to D-Param feature. Now it supports native stake (mNIGHT) validators to take part in the consensus.
link
Checklist
changelog.mdfor affected crate