-
Notifications
You must be signed in to change notification settings - Fork 21
change: ETCM-12220 Support tx-out.value = "consumed" Db-Sync option #949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change: ETCM-12220 Support tx-out.value = "consumed" Db-Sync option #949
Conversation
Adding new queries instead of replacing existing ones and making decision in runtime which to use will cost us less than all the fallout of in-place change. |
5ca2c0d
to
1b7d2ad
Compare
c9d44a5
to
7a92ee2
Compare
40cf253
to
7a92ee2
Compare
e2bf574
to
f94aa34
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but what happens if insert_options.tx_output.value
option is not present, do we have any idea how to handle it or such situation is impossible?
152b29e
to
2924e11
Compare
2924e11
to
08d723d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fill changelog and docs
Added changelog. The docs are already updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just please fix changelog, the config field name is invalid there
f3863f7
to
43d8b8a
Compare
fb29125
to
306cd7b
Compare
705e05f
to
c6fe667
Compare
Description
consumed_by_tx_id
column intx_out
instead of joins withtx_in
table. This column is populated whentx-out.value
in db-sync config is set to "consumed"TxInConfiguration { Legacy, Consumed }
which signifies which set of queries should be used.TxInConfiguration
TxInConfiguration
value is determined by checking whethertx_in
table exists and is populatedChecklist
changelog.md
for affected crate