Multi-seize feature #99
Conversation
j-mueller
left a comment
j-mueller
left a comment
There was a problem hiding this comment.
Looks good, couple of minor comments. The documentation on multi-seize is good, but I think this would be a great feature for some property tests.
| ensure that the specific issuer logic stake script witness is included in the | ||
| final transaction. | ||
| NOTE: Seems the issuer is only able to seize 1 UTxO at a time. |
There was a problem hiding this comment.
This note can be deleted now
| MonadBuildTx era m | ||
| ) => | ||
| UTxODat era ProgrammableLogicGlobalParams -> | ||
| [UTxODat era a] -> |
There was a problem hiding this comment.
Haddocks on the parameters would be nice
| -- Finds the index of the first output to the programmable logic base credential | ||
| firstSeizeContinuationOutputIndex txBody = | ||
| fromIntegral @Int @Integer $ | ||
| fromJust $ |
There was a problem hiding this comment.
If this returns Nothing then tx balancing will fail with a weird error. We could use fromMaybe (error "seizingInputIndex not found") instead of fromJust to make it slightly better
There was a problem hiding this comment.
Fixed as suggested.
| addOutput $ payToAddressTxOut destinationAddress seizedVal | ||
|
|
||
| -- This function should probably accept the programmable token policy which we want to seize as a parameter. | ||
| -- As of now, it just assumes that the first non-ada token in the seizing inputs is the token we want to seize. |
There was a problem hiding this comment.
Isn't toSeizePolicyId the policy which we want to seize?
| } | ||
|
|
||
| -- TODO: Implement efficient comparison of all fields of TxOut except value. | ||
| -- pconstructExpectedOutputWithOutputDatum :: Term s PAddress -> Term s (PAsData (PValue 'Sorted 'Positive)) -> Term s POutputDatum -> Term s (PAsData PTxOut) |
There was a problem hiding this comment.
Added more details, left as a future optimization.
|
|
||
|
|
||
|
|
||
| -- pif (pfromData inputValueEntryCS #== pfromData (pfstBuiltin # outputValueEntry)) |
|
Expanded the web-app to allow anyone to mint, transfer, and manage their own programmable token under the freeze & seize substandard. |
|
One of the use case for bulk seize was for instance, in case the programmable token was a security, to pay dividends w/o having to spend minutxo, does the current implementation support that? |
Yes, the contracts as implemented should support that. The programmable token example used in the frontend currently (freeze & seize) does not have this functionality; however, I'll try to add it to the frontend demo as-well. |
|
I updated the generated files, but there are still some Typescript errors in frontend/src/app/store/store.tsx (the |
On-chain implementation that introduces support for third party transfer logic across multiple UTxOs in a single transaction.