!fix usbd stop ep - after reset there was leaved enabled ep with broken transfers #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… stop. if ep leaved enabled -
it miss new requests until transfer completes;
lib/usbd/backend/usbd_dwc_otg.c
Outdated
| @@ -173,11 +173,11 @@ static void disable_all_non_ep0(usbd_device *dev) | |||
|
|
|||
| REBASE(DWC_OTG_DOEPxINT, i) = 0xFFFF; | |||
| REBASE(DWC_OTG_DOEPxTSIZ, i) = 0; | |||
| REBASE(DWC_OTG_DOEPxCTL, i) = DWC_OTG_DOEPCTL_SNAK; | |||
| REBASE(DWC_OTG_DOEPxCTL, i) = DWC_OTG_DOEPCTL_SNAK | DWC_OTG_DOEPCTL_EPDIS; | |||
There was a problem hiding this comment.
That is why a NAK has been placed on the endpoint (to mark as not an active endpoint).
host is not expected to IO from the endpoint.
Also, who is handling the endpoint disable interrupt callback?
… set! also
better to avoid EPDIS interrupt for normaly completed and disabled endpoints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
here patch ensures disabling endpoints when disble or endpoint stop requested.
enabled endpoints for hunged transfers was leaved enabled after reset, or urb cancel. therefore this enpoints fails to start new request validly.