Use is_pkg_installed() directly#305
Closed
MichaelChirico wants to merge 2 commits intoinsightsengineering:mainfrom
Closed
Use is_pkg_installed() directly#305MichaelChirico wants to merge 2 commits intoinsightsengineering:mainfrom
MichaelChirico wants to merge 2 commits intoinsightsengineering:mainfrom
Conversation
Signed-off-by: Michael Chirico <chiricom@google.com>
Contributor
|
✅ All contributors have signed the CLA |
Collaborator
|
Hi @MichaelChirico ! Thanks for cleaning this up! This was older syntax leftover from when the function was being called from another pkg, and it wasn't even exported (all pre-CRAN release). This is much easier on the eyes! Can you reply to this post with the following text and I can merge?
|
Author
|
Hmm sorry. Our lawyers are being very particular. I cannot sign the CLA until #309 is handled. |
13 tasks
ddsjoberg
pushed a commit
that referenced
this pull request
Nov 10, 2025
**What changes are proposed in this pull request?** * Updated tests to use standalone function `skip_if_pkg_not_installed()`. Result of changes in insightsengineering/standalone#27 Closes #306 Incorporates changes from #305 #307 #308 -------------------------------------------------------------------------------- Pre-review Checklist (if item does not apply, mark is as complete) - [x] **All** GitHub Action workflows pass with a ✅ - [x] PR branch has pulled the most recent updates from master branch: `usethis::pr_merge_main()` - [x] If a bug was fixed, a unit test was added. - [x] If a new `ard_*()` function was added, it passes the ARD structural checks from `cards::check_ard_structure()`. - [x] If a new `ard_*()` function was added, `set_cli_abort_call()` has been set. - [x] If a new `ard_*()` function was added and it depends on another package (such as, `broom`), `is_pkg_installed("broom")` has been set in the function call and the following added to the roxygen comments: `@examplesIf do.call(asNamespace("cardx")$is_pkg_installed, list(pkg = "broom""))` - [x] Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): `devtools::test_coverage()` Reviewer Checklist (if item does not apply, mark is as complete) - [ ] If a bug was fixed, a unit test was added. - [ ] Code coverage is suitable for any new functions/features: `devtools::test_coverage()` When the branch is ready to be merged: - [ ] Update `NEWS.md` with the changes from this pull request under the heading "`# cardx (development version)`". If there is an issue associated with the pull request, reference it in parentheses at the end update (see `NEWS.md` for examples). - [ ] **All** GitHub Action workflows pass with a ✅ - [ ] Approve Pull Request - [ ] Merge the PR. Please use "Squash and merge" or "Rebase and merge".
Collaborator
|
Updated in another PR, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
testthat makes the cardx namespace available; this style results in ugly test log notes like: