Skip to content

Add coda package dependency#324

Merged
shajoezhu merged 6 commits intomainfrom
shajoezhu-patch-1
Nov 27, 2025
Merged

Add coda package dependency#324
shajoezhu merged 6 commits intomainfrom
shajoezhu-patch-1

Conversation

@shajoezhu
Copy link
Copy Markdown
Contributor

What changes are proposed in this pull request?

  • Style this entry in a way that can be copied directly into NEWS.md. (#, @)

Provide more detail here as needed.

Reference GitHub issue associated with pull request. e.g., 'closes #'


Pre-review Checklist (if item does not apply, mark is as complete)

  • All GitHub Action workflows pass with a ✅
  • PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
  • If a bug was fixed, a unit test was added.
  • If a new ard_*() function was added, it passes the ARD structural checks from cards::check_ard_structure().
  • If a new ard_*() function was added, set_cli_abort_call() has been set.
  • If a new ard_*() function was added and it depends on another package (such as, broom), is_pkg_installed("broom") has been set in the function call and the following added to the roxygen comments: @examplesIf do.call(asNamespace("cardx")$is_pkg_installed, list(pkg = "broom""))
  • Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): devtools::test_coverage()

Reviewer Checklist (if item does not apply, mark is as complete)

  • If a bug was fixed, a unit test was added.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()

When the branch is ready to be merged:

  • Update NEWS.md with the changes from this pull request under the heading "# cardx (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • All GitHub Action workflows pass with a ✅
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge" or "Rebase and merge".

Signed-off-by: Joe Zhu <sha.joe.zhu@gmail.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 25, 2025

badge

Code Coverage Summary

Filename                                Stmts    Miss  Cover    Missing
------------------------------------  -------  ------  -------  -------------------------------------------
R/add_total_n.survey.design.R              10       0  100.00%
R/ard_aod_wald_test.R                      77       2  97.40%   93, 96
R/ard_attributes.survey.design.R            2       0  100.00%
R/ard_car_anova.R                          45       2  95.56%   62, 65
R/ard_car_vif.R                            62       1  98.39%   87
R/ard_categorical_ci.R                    323       1  99.69%   100
R/ard_categorical_ci.survey.design.R      124       1  99.19%   180
R/ard_continuous_ci.R                      28       1  96.43%   38
R/ard_continuous_ci.survey.design.R       138       0  100.00%
R/ard_continuous.survey.design.R          284      20  92.96%   61-66, 100, 191, 201, 352, 383-384, 435-443
R/ard_effectsize_cohens_d.R               103       2  98.06%   69, 122
R/ard_effectsize_hedges_g.R                91       2  97.80%   68, 120
R/ard_emmeans_contrast.R                   99       0  100.00%
R/ard_emmeans_emmeans.R                    97       0  100.00%
R/ard_incidence_rate.R                    104       0  100.00%
R/ard_missing.survey.design.R              89       7  92.13%   45-50, 63
R/ard_regression_basic.R                   31       1  96.77%   61
R/ard_regression.R                         87       0  100.00%
R/ard_smd_smd.R                            69       5  92.75%   57, 83-86
R/ard_stats_anova.R                        95       0  100.00%
R/ard_stats_aov.R                          46       0  100.00%
R/ard_stats_chisq_test.R                   40       1  97.50%   39
R/ard_stats_fisher_test.R                  43       1  97.67%   42
R/ard_stats_kruskal_test.R                 36       1  97.22%   38
R/ard_stats_mantelhaen_test.R              67       1  98.51%   45
R/ard_stats_mcnemar_test.R                 80       2  97.50%   63, 106
R/ard_stats_mood_test.R                    49       1  97.96%   45
R/ard_stats_oneway_test.R                  39       0  100.00%
R/ard_stats_poisson_test.R                 76       1  98.68%   59
R/ard_stats_prop_test.R                    85       1  98.82%   43
R/ard_stats_t_test_onesample.R             41       0  100.00%
R/ard_stats_t_test.R                      112       2  98.21%   65, 111
R/ard_stats_wilcox_test_onesample.R        42       0  100.00%
R/ard_stats_wilcox_test.R                  99       2  97.98%   65, 117
R/ard_survey_svychisq.R                    38       1  97.37%   44
R/ard_survey_svyranktest.R                 54       1  98.15%   44
R/ard_survey_svyttest.R                    53       1  98.11%   42
R/ard_survival_survdiff.R                  89       0  100.00%
R/ard_survival_survfit_diff.R              76       0  100.00%
R/ard_survival_survfit.R                  236       5  97.88%   234-238
R/ard_tabulate_abnormal.R                  76       0  100.00%
R/ard_tabulate_max.R                       51       7  86.27%   54-59, 74
R/ard_tabulate_value.survey.design.R       80       9  88.75%   40-45, 62, 167, 172
R/ard_tabulate.survey.design.R            407      15  96.31%   70-75, 90, 244-247, 291, 336, 536, 550
R/construction_helpers.R                  106      10  90.57%   160-175, 189, 248
R/deprecated.R                             34      34  0.00%    28-86
R/proportion_ci.R                         203       1  99.51%   463
TOTAL                                    4316     142  96.71%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 25aeabc

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 25, 2025

Unit Tests Summary

  1 files  189 suites   1m 22s ⏱️
187 tests 187 ✅ 0 💤 0 ❌
781 runs  781 ✅ 0 💤 0 ❌

Results for commit 25aeabc.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 25, 2025

Unit Test Performance Difference

Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
ard_summary.survey.design 💔 $23.88$ $+1.13$ unstratified_ard_summary.survey.design_works

Results for commit d009df1

♻️ This comment has been updated with latest results.

Signed-off-by: Joe Zhu <sha.joe.zhu@gmail.com>
Signed-off-by: Joe Zhu <sha.joe.zhu@gmail.com>
Signed-off-by: Joe Zhu <sha.joe.zhu@gmail.com>
Signed-off-by: Joe Zhu <sha.joe.zhu@gmail.com>
Signed-off-by: Joe Zhu <sha.joe.zhu@gmail.com>
@shajoezhu shajoezhu enabled auto-merge (squash) November 26, 2025 10:02
@shajoezhu shajoezhu merged commit de34520 into main Nov 27, 2025
41 checks passed
@shajoezhu shajoezhu deleted the shajoezhu-patch-1 branch November 27, 2025 14:23
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2025
@ddsjoberg
Copy link
Copy Markdown
Collaborator

What does adding these package deps do for us?

@ddsjoberg
Copy link
Copy Markdown
Collaborator

What does adding these package deps do for us?

@shajoezhu @edelarua what does adding these dependencies do for the package? Thanks

@shajoezhu
Copy link
Copy Markdown
Contributor Author

hi @ddsjoberg , i am preparing package releases, https://github.com/pawelru/ie_status

there was some minor version case, probably upversioning one of the imports will fix it, but i didn't want to cause any touble downstream with gtsummary, so just updated the suggests

@ddsjoberg
Copy link
Copy Markdown
Collaborator

thanks @shajoezhu !

Honestly, I am confused. what does adding additional deps to the package that are not needed by the package do for us?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants