Conversation
Signed-off-by: Joe Zhu <sha.joe.zhu@gmail.com>
Code Coverage SummaryDiff against mainResults for commit: 25aeabc Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 189 suites 1m 22s ⏱️ Results for commit 25aeabc. ♻️ This comment has been updated with latest results. |
Unit Test Performance DifferenceAdditional test case details
Results for commit d009df1 ♻️ This comment has been updated with latest results. |
Signed-off-by: Joe Zhu <sha.joe.zhu@gmail.com>
Signed-off-by: Joe Zhu <sha.joe.zhu@gmail.com>
Signed-off-by: Joe Zhu <sha.joe.zhu@gmail.com>
Signed-off-by: Joe Zhu <sha.joe.zhu@gmail.com>
Signed-off-by: Joe Zhu <sha.joe.zhu@gmail.com>
|
What does adding these package deps do for us? |
@shajoezhu @edelarua what does adding these dependencies do for the package? Thanks |
|
hi @ddsjoberg , i am preparing package releases, https://github.com/pawelru/ie_status there was some minor version case, probably upversioning one of the imports will fix it, but i didn't want to cause any touble downstream with gtsummary, so just updated the suggests |
|
thanks @shajoezhu ! Honestly, I am confused. what does adding additional deps to the package that are not needed by the package do for us? |
What changes are proposed in this pull request?
NEWS.md. (#, @)Provide more detail here as needed.
Reference GitHub issue associated with pull request. e.g., 'closes #'
Pre-review Checklist (if item does not apply, mark is as complete)
usethis::pr_merge_main()ard_*()function was added, it passes the ARD structural checks fromcards::check_ard_structure().ard_*()function was added,set_cli_abort_call()has been set.ard_*()function was added and it depends on another package (such as,broom),is_pkg_installed("broom")has been set in the function call and the following added to the roxygen comments:@examplesIf do.call(asNamespace("cardx")$is_pkg_installed, list(pkg = "broom""))devtools::test_coverage()Reviewer Checklist (if item does not apply, mark is as complete)
devtools::test_coverage()When the branch is ready to be merged:
NEWS.mdwith the changes from this pull request under the heading "# cardx (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (seeNEWS.mdfor examples).