Skip to content

Conversation

@gmbecker
Copy link
Collaborator

@gmbecker gmbecker commented Dec 9, 2025

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

badge

Code Coverage Summary

Filename                     Stmts    Miss  Cover    Missing
-------------------------  -------  ------  -------  -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
R/00tabletrees.R               832      63  92.43%   20, 94, 97, 428, 519-520, 523, 681, 785, 877-878, 980, 983, 985-986, 1004-1007, 1027, 1142-1145, 1243-1248, 1411, 1512-1515, 1639-1642, 1679-1682, 1688-1693, 1753, 1760, 1856, 1968, 1981, 1984-1987, 1990-1993, 2023, 2056-2057
R/as_html.R                    172      25  85.47%   5-10, 80, 152-157, 162-167, 182-186, 273
R/colby_constructors.R         605      26  95.70%   81, 134, 197-200, 267-270, 411, 427, 1203, 1292, 1453, 1492, 1503, 1511, 1514, 1539, 1560, 1706, 1929-1932
R/compare_rtables.R             83      17  79.52%   93-96, 99-102, 115-118, 137, 156-157, 188, 193
R/custom_split_funs.R          265      40  84.91%   127, 132, 138-143, 156, 173-177, 353-358, 375-380, 456, 502, 518-521, 537, 599, 609-610, 612, 624, 668, 693
R/default_split_funs.R         287      22  92.33%   272, 335-338, 349-350, 352, 354, 551-555, 619-622, 685-688
R/format_rcell.R                17       1  94.12%   47
R/indent.R                      13       2  84.62%   40-41
R/index_footnotes.R             66       0  100.00%
R/make_split_fun.R             138      31  77.54%   22-26, 36-39, 52-55, 58-61, 115, 119, 267, 270-273, 278-281, 295, 366, 375, 377, 379, 430
R/make_subset_expr.R           137      15  89.05%   35, 47-61, 135-142, 178, 267, 271, 280
R/summary.R                    144      38  73.61%   35, 80, 178-220, 269, 315-331, 366, 397
R/tree_accessors.R            1275     148  88.39%   110, 139-140, 264, 284, 310, 333, 363, 381, 400-404, 424, 446-449, 564, 591-592, 878-884, 1028, 1047, 1073, 1125, 1182-1183, 1220, 1255, 1293-1298, 1357, 1431-1435, 1453-1462, 1540, 1660-1663, 1688, 1710-1711, 1721, 1772, 1793-1798, 1819-1824, 1835, 1909, 1950, 2049, 2156, 2169, 2183, 2199, 2208, 2218-2222, 2272-2277, 2480, 2490-2493, 2503, 2528-2531, 2538, 2540-2543, 2665, 2699-2700, 2757, 3061, 3422, 3538, 3572-3597, 3688-3696, 3857, 3931-3937, 4242, 4366, 4451-4456, 4462, 4486-4491, 4539, 4564-4588, 4617-4623
R/tt_afun_utils.R              419      33  92.12%   60, 182, 189, 198-212, 280, 288-289, 507, 515-518, 600-604, 624, 638-640
R/tt_as_df.R                   400      23  94.25%   101-104, 112, 150, 224-227, 369, 388, 458, 477-480, 489, 599, 605, 637, 655, 707
R/tt_compare_tables.R           72       4  94.44%   51, 174, 249, 253
R/tt_compatibility.R           574      70  87.80%   22, 149-150, 193, 198, 329-330, 334-337, 343, 347, 531, 585-588, 625-627, 665, 698, 718, 738-741, 751-754, 799, 816-820, 826-829, 903, 930-933, 942, 1004, 1012, 1023-1026, 1137, 1144, 1172-1186, 1217-1218
R/tt_dotabulation.R           1176      95  91.92%   60, 255, 260, 262, 311, 336, 340-343, 376-379, 402, 435-438, 466-469, 567, 709-713, 763, 767, 795-798, 808, 828-832, 839-842, 1106, 1110, 1141, 1245-1248, 1462-1470, 1734-1743, 1825-1828, 1839, 1844, 1849-1850, 1852, 1863, 1868, 1891, 1977-1996
R/tt_export.R                   13       1  92.31%   45
R/tt_from_df.R                  15       0  100.00%
R/tt_paginate.R                535      40  92.52%   74, 122-131, 243, 342-343, 495, 630-633, 654-658, 803-806, 857-864, 941, 944, 962, 969, 972
R/tt_pos_and_access.R          656      33  94.97%   76, 78-80, 105, 166, 262, 329, 438, 512, 516, 724, 726, 734, 740, 754, 764-767, 990, 1007-1010, 1037, 1096-1097, 1110, 1346-1347, 1373-1376, 1650, 1725
R/tt_showmethods.R             162      21  87.04%   56, 91-113, 223, 249, 258, 263, 266-270, 359-360
R/tt_sort.R                    115       6  94.78%   50, 289-292, 300
R/tt_toString.R                439      24  94.53%   125, 355, 377, 390, 400, 406, 409, 415-425, 518, 619, 826-851
R/utils.R                       34       7  79.41%   56, 169-174
R/validate_table_struct.R       84      10  88.10%   80-84, 93-94, 140, 149-150
R/Viewer.R                      61       9  85.25%   46, 50, 60-64, 84, 118
TOTAL                         8789     804  90.85%

Diff against main

Filename                 Stmts    Miss  Cover
---------------------  -------  ------  -------
R/tt_pos_and_access.R       +2       0  +0.02%
TOTAL                       +2       0  +0.00%

Results for commit: 85da6d1

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

Unit Tests Summary

    1 files     29 suites   1m 48s ⏱️
  245 tests   245 ✅ 0 💤 0 ❌
1 813 runs  1 813 ✅ 0 💤 0 ❌

Results for commit 85da6d1.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

Unit Test Performance Difference

Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
Accessing and subsetting tables 👶 $+0.84$ cell_values_colpath_does_not_choke_on_regex_chars_in_path

Results for commit 362809d

♻️ This comment has been updated with latest results.

@gmbecker
Copy link
Collaborator Author

@shajoezhu @Melkiades only 'failing' check is the spell check failing on the accents in Daniel's name (again), so this should be good to merge. Clean pass for scda.test at insightsengineering/scda.test#202

Please review

@gmbecker gmbecker requested a review from shajoezhu December 10, 2025 19:46
@danielinteractive
Copy link
Contributor

Sorry guys! 😄
image

@shajoezhu shajoezhu enabled auto-merge (squash) December 11, 2025 01:08
Copy link
Collaborator

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks @gmbecker

@shajoezhu shajoezhu merged commit 8cdce34 into main Dec 11, 2025
29 checks passed
@shajoezhu shajoezhu deleted the 1058_label_regex_chars branch December 11, 2025 01:19
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants