-
Notifications
You must be signed in to change notification settings - Fork 53
fix candidate for 1058 #1063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix candidate for 1058 #1063
Conversation
Code Coverage SummaryDiff against mainResults for commit: 85da6d1 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 29 suites 1m 48s ⏱️ Results for commit 85da6d1. ♻️ This comment has been updated with latest results. |
Unit Test Performance DifferenceAdditional test case details
Results for commit 362809d ♻️ This comment has been updated with latest results. |
|
@shajoezhu @Melkiades only 'failing' check is the spell check failing on the accents in Daniel's name (again), so this should be good to merge. Clean pass for scda.test at insightsengineering/scda.test#202 Please review |
Signed-off-by: Joe Zhu <[email protected]>
shajoezhu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! thanks @gmbecker

downstream tests: insightsengineering/scda.test#202