Use pharmaverseadam data in safety templates - part 2

[edelarua]

Closes #147

[github-actions]

Unit Tests Summary

  1 files  111 suites   3m 26s ⏱️
243 tests 243 ✅ 0 💤 0 ❌
513 runs  513 ✅ 0 💤 0 ❌

Results for commit 1c9fce1.

♻️ This comment has been updated with latest results.

[github-actions]

Unit Test Performance Difference

Test Suite	$Status$	Time on main	$±Time$	$±Tests$	$±Skipped$	$±Failures$	$±Errors$
table_egt01	💔	$1.48$	$+1.80$	$0$	$0$	$0$	$0$
table_egt02	💔	$0.56$	$+1.04$	$0$	$0$	$0$	$0$
table_egt04	💔	$0.25$	$+1.23$	$0$	$0$	$0$	$0$
table_egt05_qtcat	💔	$0.80$	$+1.43$	$0$	$0$	$0$	$0$
table_vst01	💔	$1.04$	$+1.14$	$0$	$0$	$0$	$0$

Additional test case details

Test Suite	$Status$	Time on main	$±Time$	Test Case
table_egt01	💔	$1.48$	$+1.80$	EGT01_default_variant_is_produced_correctly
table_egt02	💔	$0.34$	$+1.00$	_EGT02_1._Regardless_of_Abnormality_at_Baseline
table_egt04	💔	$0.25$	$+1.23$	EGT04_default_variant_is_produced_correctly
table_egt05_qtcat	💔	$0.80$	$+1.43$	EGT05_QTCAT_default_variant_is_produced_correctly
table_vst01	💔	$1.04$	$+1.14$	VST01_default_variant_is_produced_correctly

Results for commit 7f78ee5

♻️ This comment has been updated with latest results.

[shajoezhu]

blocked by #159

[shajoezhu]

hi @edelarua, can you please check these numbers, I think we need to dig into the data a bit more. thank you

[shajoezhu]

hi @edelarua , we are almost there. I was wondering if you can look into this one please https://github.com/insightsengineering/scda.test/actions/runs/11712269992/job/32622560335?pr=154#step:42:187

[edelarua]

hi @edelarua , we are almost there. I was wondering if you can look into this one please https://github.com/insightsengineering/scda.test/actions/runs/11712269992/job/32622560335?pr=154#step:42:187

Hi @shajoezhu,
It seems like the vst01 snapshot is not skipped by the non-CRAN checks like it is by the CRAN checks. I have manually bypassed the skip and regenerated the snapshot so all are passing now!

[shajoezhu]

hi @edelarua , we are almost there. I was wondering if you can look into this one please https://github.com/insightsengineering/scda.test/actions/runs/11712269992/job/32622560335?pr=154#step:42:187

Hi @shajoezhu, It seems like the vst01 snapshot is not skipped by the non-CRAN checks like it is by the CRAN checks. I have manually bypassed the skip and regenerated the snapshot so all are passing now!

this is weird behavior. Thanks @edelarua .

@pawelru I was wondering do you have any insights with why it is skipping one, but not the other?

[shajoezhu]

block this PR by #161

[pawelru]

snapshot testing are skipped by default for CRAN checks
(on contrary: snapshot tests are enabled for non-CRAN checks)

this is nicely explained here: https://github.com/insightsengineering/idr-tasks/issues/794#issue-2351144387

[shajoezhu]

hi @edelarua , we will follow up with the egt table later when new data become available. could you update the snapshot tests, and will merge this PR in. Thanks!

[edelarua]

hi @edelarua , we will follow up with the egt table later when new data become available. could you update the snapshot tests, and will merge this PR in. Thanks!

@shajoezhu sounds good! The snapshots are up to date as of our last discussion and should be good to go. It seems like the Pkgdown Docs check is still using staged dependencies and so is failing. Is there a way to fix this, or can it be ignored?

[shajoezhu]

hi @edelarua , we will follow up with the egt table later when new data become available. could you update the snapshot tests, and will merge this PR in. Thanks!

@shajoezhu sounds good! The snapshots are up to date as of our last discussion and should be good to go. It seems like the Pkgdown Docs check is still using staged dependencies and so is failing. Is there a way to fix this, or can it be ignored?

thanks @edelarua , let me give it a go

[shajoezhu]

lgtm! thanks @edelarua