Skip to content

Conversation

@edelarua
Copy link
Contributor

@edelarua edelarua commented May 20, 2025

Closes #193


Summary of data changes (all from pharmaverseadam v1.1.0.9001):

Change to ADPC:

  • Split 24-48h Post-dose records into two records identical except that one has DTYPE = HALFLLOQ and the other has AVAL = NA

Change to ADEG:

  • Minor text changes to EGSTRESU (unit variable):
    • BEATS/MIN --> beats/min
    • msec --> ms

@edelarua edelarua added the sme label May 20, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 20, 2025

Unit Tests Summary

  1 files  112 suites   3m 19s ⏱️
249 tests 218 ✅  31 💤 0 ❌
487 runs  240 ✅ 247 💤 0 ❌

Results for commit 0965fec.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
pagination_table 💚 $14.66$ $-2.50$ $-9$ $+6$ $0$ $0$
table_aet03 💚 $5.24$ $-3.48$ $-4$ $+1$ $0$ $0$
table_aet04 💚 $12.63$ $-6.67$ $-14$ $+8$ $0$ $0$
table_pkct01 💚 $3.52$ $-1.91$ $-6$ $+2$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
pagination_table 💚 $3.83$ $-2.36$ Pagination_works_for_page_types
table_aet03 💚 $5.25$ $-3.49$ AET03_variant_1_is_produced_correctly
table_aet04 💚 $2.08$ $-1.06$ AET04_variant_1_is_produced_correctly
table_pkct01 💚 $2.90$ $-1.65$ Specific_PKCT01_features_are_present

Results for commit 268b1f3

♻️ This comment has been updated with latest results.

Copy link
Contributor

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks a lot Em!

@edelarua edelarua merged commit 4603ce3 into main May 20, 2025
29 checks passed
@edelarua edelarua deleted the 193_data_updates branch May 20, 2025 22:14
@github-actions github-actions bot locked and limited conversation to collaborators May 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Investigate PK table changes after ADPC data update

3 participants