Skip to content

Conversation

@iaugusty
Copy link
Collaborator

Added a test to check that a factor variable with all values missing would produce a correct table using tern::analyze_vars

Added a test to check that a factor variable with all values missing would produce a correct table using tern::analyze_vars
@github-actions
Copy link
Contributor

github-actions bot commented Aug 29, 2025

✅ All contributors have signed the CLA
Posted by the CLA Assistant Lite bot.

@iaugusty
Copy link
Collaborator Author

I have read the CLA Document and I hereby sign the CLA

@github-actions
Copy link
Contributor

github-actions bot commented Aug 29, 2025

Unit Tests Summary

  1 files  113 suites   3m 29s ⏱️
250 tests 250 ✅ 0 💤 0 ❌
526 runs  526 ✅ 0 💤 0 ❌

Results for commit de53b02.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 29, 2025

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
pagination_listing 💚 $5.84$ $-2.18$ $0$ $0$ $0$ $0$
pagination_table 💔 $11.96$ $+1.03$ $+9$ $-6$ $0$ $0$
table_aet03 💔 $1.73$ $+2.80$ $+4$ $-1$ $0$ $0$
table_aet04 💔 $5.97$ $+6.23$ $+14$ $-8$ $0$ $0$
table_jnj_tbl1 👶 $+0.29$ $+2$ $0$ $0$ $0$
table_pkct01 💔 $1.62$ $+1.61$ $+6$ $-2$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
pagination_listing 💚 $2.69$ $-1.25$ pagination_counts_the_right_number_of_lines_when_wrapping_on_keycols_is_present
pagination_table 💔 $1.45$ $+1.87$ Pagination_works_for_page_types
table_aet03 💔 $1.73$ $+2.80$ AET03_variant_1_is_produced_correctly
table_jnj_tbl1 👶 $+0.29$ DMT01_variant_factor_with_only_Missing_values
table_pkct01 💔 $1.26$ $+1.42$ Specific_PKCT01_features_are_present

Results for commit 20e20bc

♻️ This comment has been updated with latest results.

@iaugusty iaugusty requested a review from shajoezhu August 29, 2025 10:53
Copy link
Contributor

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! given tern is merged into main, this is good to go

Signed-off-by: Joe Zhu <[email protected]>
Signed-off-by: Joe Zhu <[email protected]>
Copy link
Contributor

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@shajoezhu shajoezhu merged commit bbe42cb into main Oct 10, 2025
52 of 53 checks passed
@shajoezhu shajoezhu deleted the extra_tests_jj branch October 10, 2025 06:27
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants