Skip to content

Commit 620849b

Browse files
committed
pr: apply suggestions
1 parent c76e148 commit 620849b

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

NEWS.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,9 @@
44

55
* `get_code()` was extended with `names` parameter and allows the code extraction to be limited to objects stored in
66
`qenv` but limited to `names`.
7-
* `qenv` inherits from the `environment` class, allowing to use `names()`, `as.environment()`, R operators (`[[` and `$`) and other functions on `qenv` objects.
7+
* `qenv` inherits from the `environment` class, allowing to use `ls()`, `names()`, `as.environment()` and other functions on `qenv` objects.
8+
* `join()` method is deprecated, please use `c()` instead
9+
* `get_var()` method is deprecated, please use `get`, `[[` or `$` instead.
810

911
# teal.code 0.5.0
1012

tests/testthat/test-qenv_constructor.R

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,3 @@ testthat::describe("parent of qenv environment is the parent of .GlobalEnv", {
6060
testthat::expect_identical(parent.env(q), parent.env(.GlobalEnv))
6161
})
6262
})
63-
64-
testthat::test_that("qenv environment is locked", {
65-
q <- qenv()
66-
testthat::expect_error(q@.xData$x <- 1, "cannot add bindings to a locked environment")
67-
})

0 commit comments

Comments
 (0)