-
-
Notifications
You must be signed in to change notification settings - Fork 8
introduce label to eval_code, within and get_code
#248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Code Coverage SummaryDiff against mainResults for commit: 2ff3aeb Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Contributor
Unit Tests Summary 1 files 12 suites 3s ⏱️ Results for commit 2ff3aeb. ♻️ This comment has been updated with latest results. |
Contributor
Unit Test Performance DifferenceAdditional test case details
Results for commit 247c88d ♻️ This comment has been updated with latest results. |
15 tasks
5 tasks
1 task
Contributor
|
We decided to not implement this |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposition to close #241
#241 is a bit outdated, there no longer is
id/indexfield. We now have@codefield that has integers as names.I decided to introduce label added to
@codeelements that can be used to trim code withget_code(labels).I did not decide to change implementation so that it is possible to pass
id/nameof the@codeelement because when you passcodetoeval_codeit might be divided into multiple elements in the output@code. names of@codeshould be unique so that we can usejoin_qenvand similar functions. So it's actually hard to know what length of unique ids should be passed ineval_codefor a specific code input (that then will be divided into multiple elements).I decided that you can pass a label that is assigned as an attribute, and can be non-unique between elements of
@code.Created on 2025-03-27 with reprex v2.1.1