Skip to content

Conversation

@m7pr
Copy link
Contributor

@m7pr m7pr commented Aug 11, 2025

Both experimental and deprecated badges were added at the latest version 0.6.1 so no need for the updates #239
Only added experimental for the new function: get_outputs.

@m7pr m7pr requested a review from gogonzo August 11, 2025 09:47
@m7pr m7pr added the core label Aug 11, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 11, 2025

badge

Code Coverage Summary

Filename                         Stmts    Miss  Cover    Missing
-----------------------------  -------  ------  -------  -------------
R/qenv-c.R                          55       0  100.00%
R/qenv-class.R                      13       0  100.00%
R/qenv-concat.R                      7       0  100.00%
R/qenv-constructor.R                 1       0  100.00%
R/qenv-errors.R                      4       4  0.00%    6-9
R/qenv-eval_code.R                  60       1  98.33%   40
R/qenv-extract.R                    30       0  100.00%
R/qenv-get_code.R                   24       0  100.00%
R/qenv-get_env.R                     3       1  66.67%   27
R/qenv-get_messages.r                5       0  100.00%
R/qenv-get_outputs.R                 6       0  100.00%
R/qenv-get_var.R                    13       1  92.31%   13
R/qenv-get_warnings.R                5       0  100.00%
R/qenv-join.R                        1       1  0.00%    13
R/qenv-length.R                      2       1  50.00%   2
R/qenv-show.R                       29      29  0.00%    19-50
R/qenv-within.R                      8       0  100.00%
R/utils-get_code_dependency.R      254       3  98.82%   160, 258, 331
R/utils.R                           42       0  100.00%
TOTAL                              562      41  92.70%

Diff against main

Filename            Stmts    Miss  Cover
----------------  -------  ------  --------
R/qenv-get_var.R      -13      +1  -7.69%
R/qenv-join.R          -6      -6  +100.00%
TOTAL                 -19      -5  +0.62%

Results for commit: aa1a5ba

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Aug 11, 2025

Unit Tests Summary

  1 files   14 suites   5s ⏱️
171 tests 168 ✅ 3 💤 0 ❌
254 runs  251 ✅ 3 💤 0 ❌

Results for commit aa1a5ba.

♻️ This comment has been updated with latest results.

@gogonzo
Copy link
Contributor

gogonzo commented Aug 11, 2025

Both experimental and deprecated badges were added at the latest version 0.6.1 so no need for the updates #239 Only added experimental for the new function: get_outputs.

All deprecations have been added at 0.6.0 which means that we should deprecate_stop now

Skärmavbild 2025-08-11 kl  15 35 19

@gogonzo gogonzo self-assigned this Aug 11, 2025
@m7pr
Copy link
Contributor Author

m7pr commented Aug 11, 2025

@gogonzo for the deprecate_stop do you think we should deleted examples, tests and body of the function (besides the lifecycle check)?

@gogonzo
Copy link
Contributor

gogonzo commented Aug 12, 2025

@gogonzo for the deprecate_stop do you think we should deleted examples, tests and body of the function (besides the lifecycle check)?

Yes

@m7pr
Copy link
Contributor Author

m7pr commented Aug 12, 2025

Her deprecated methods in fcf46ed

@m7pr m7pr requested a review from gogonzo August 12, 2025 07:41
@github-actions
Copy link
Contributor

github-actions bot commented Aug 12, 2025

Unit Test Performance Difference

Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
qenv_get_var 👶 $+0.01$ and_only_returns_objects_from_qenv_not.GlobalEnv
qenv_get_var 👶 $+0.01$ and_only_returns_objects_from_qenv_not_parent_environment_s
qenv_get_var 👶 $+0.03$ _and_return_NULL_if_object_not_in_qenv_environment
qenv_get_var 👶 $+0.04$ _and_return_error_if_object_is_qenv.error
qenv_get_var 👶 $+0.03$ _and_return_object_from_qenv_environment
qenv_get_var 💀 $0.01$ $-0.01$ get_var_and_only_returns_objects_from_qenv_not_.GlobalEnv
qenv_get_var 💀 $0.01$ $-0.01$ get_var_and_only_returns_objects_from_qenv_not_parent_environment_s_
qenv_get_var 💀 $0.04$ $-0.04$ get_var_and_return_NULL_if_object_not_in_qenv_environment
qenv_get_var 💀 $0.05$ $-0.05$ get_var_and_return_error_if_object_is_qenv.error
qenv_get_var 💀 $0.11$ $-0.11$ get_var_and_return_object_from_qenv_environment

Results for commit 6b4af4a

♻️ This comment has been updated with latest results.

@m7pr m7pr requested a review from gogonzo August 12, 2025 08:58
@m7pr m7pr enabled auto-merge (squash) August 12, 2025 08:58
Copy link
Contributor

@gogonzo gogonzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@m7pr m7pr merged commit 4a1f518 into main Aug 12, 2025
28 of 29 checks passed
@m7pr m7pr deleted the lifecycle@main branch August 12, 2025 09:09
@github-actions github-actions bot locked and limited conversation to collaborators Aug 12, 2025
class = c("validation", "try-error", "simpleError")
))
})
get_var <- function(...) lifecycle::deprecate_stop("0.6.0", "get_var()", "base::get()")
Copy link
Contributor

@gogonzo gogonzo Aug 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does It suppose to be when = "0.6.2"?

@vedhav
Copy link
Contributor

vedhav commented Aug 13, 2025

@insightsengineering/nest-core-dev TODO: Please update these places where teal.code::get_var are used/mentioned:

  1. In teal we use it here and it is causing the app to fail.
  2. In teal.connectors.ssh a test uses this.
  3. teal.data docs mentioned it here.

@llrs-roche
Copy link
Contributor

@insightsengineering/nest-core-dev TODO: Please update these places where teal.code::get_var are used/mentioned:

  1. In teal we use it here and it is causing the app to fail.

Couldn't find on main fixed on insightsengineering/teal#1576

The other two aren't fixed. Maybe I'll create an issue to don't forget about those (specially because it has teal.connectors.ssh repo that I was not aware of).

  1. In teal.connectors.ssh a test uses this.
  2. teal.data docs mentioned it here.
    Still there.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants