📑 Reporter Refactor: Adds support for new teal_report and teal_card class

[m7pr]

Tested with

• App that tests all the modules #359

Companion PRs:

• 📑 Reporter Refactor: Adds support for new teal_report and teal_card class teal#1541
• {teal} module returns a teal_report object that extends from teal_data teal.code#255
• {teal} module returns a teal_report object that extends from teal_data teal.data#370
• 📑 Refactor: Adds new teal_report, teal_card class and revamps reporter UI teal.reporter#331
• 📑 Reporter Refactor: Adds support for new teal_report and teal_card class teal.modules.general#884

Changes description

• Return a teal_report object on every module
• Remove old "Add to reporter" implementation in modules

[github-actions]

Code Coverage Summary

Filename                                 Stmts    Miss  Cover    Missing
-------------------------------------  -------  ------  -------  ---------------------------------------------------------
R/tm_g_gh_boxplot.R                        309      27  91.26%   358, 364, 492-499, 503-504, 545-560, 566-569
R/tm_g_gh_correlationplot.R                532     532  0.00%    229-896
R/tm_g_gh_density_distribution_plot.R      242     242  0.00%    136-452
R/tm_g_gh_lineplot.R                       519     519  0.00%    163-801
R/tm_g_gh_scatterplot.R                    221     221  0.00%    144-445
R/tm_g_gh_spaghettiplot.R                  292     292  0.00%    196-590
R/toggleable_slider.R                      112       7  93.75%   140-146
R/utils-arbitrary_lines.r                  121      14  88.43%   60, 71-74, 78, 90-93, 107, 111, 118, 122
R/utils-data_constraints.r                 189      61  67.72%   39, 57, 111-124, 126-140, 154, 175, 181, 200-226, 241-250
R/utils-maptrt.r                             9       9  0.00%    24-36
R/utils-templ_ui.r                          68      19  72.06%   2-9, 41-44, 74-80
R/utils.R                                   42      33  21.43%   5, 39-91
R/zzz.R                                      2       2  0.00%    2-3
TOTAL                                     2658    1978  25.58%

Diff against main

Filename                                 Stmts    Miss  Cover
-------------------------------------  -------  ------  --------
R/tm_g_gh_boxplot.R                        -35      -3  -0.02%
R/tm_g_gh_correlationplot.R                -35     -35  +100.00%
R/tm_g_gh_density_distribution_plot.R      -30     -30  +100.00%
R/tm_g_gh_lineplot.R                       -34     -34  +100.00%
R/tm_g_gh_scatterplot.R                    -34     -34  +100.00%
R/tm_g_gh_spaghettiplot.R                  -27     -27  +100.00%
TOTAL                                     -195    -163  +0.63%

Results for commit: e7d0f45

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

[github-actions]

Unit Tests Summary

1 files  1 suites   2m 1s ⏱️
6 tests 6 ✅ 0 💤 0 ❌
9 runs  9 ✅ 0 💤 0 ❌

Results for commit ed95681.

♻️ This comment has been updated with latest results.

[github-actions]

Unit Test Performance Difference

Test Suite	$Status$	Time on main	$±Time$	$±Tests$	$±Skipped$	$±Failures$	$±Errors$
shinytest2-tm_g_gh_boxplot	💔	$103.47$	$+17.92$	$0$	$0$	$0$	$0$

Additional test case details

Test Suite	$Status$	Time on main	$±Time$	Test Case
shinytest2-tm_g_gh_boxplot	💔	$12.65$	$+3.54$	toggle_slider_module_changing_dependant_widgets_outside_sets_proper_sliderInput_and_numericInput_values
shinytest2-tm_g_gh_boxplot	💔	$20.66$	$+4.09$	toggle_slider_module_changing_the_numericInputs_outside_the_sliderInput_range_sets_proper_sliderInput_values_and_range
shinytest2-tm_g_gh_boxplot	💔	$20.43$	$+3.11$	toggle_slider_module_changing_the_numericInputs_within_the_rage_sets_back_the_sliderInput_range_to_initial_range
shinytest2-tm_g_gh_boxplot	💔	$20.74$	$+2.57$	toggle_slider_module_changing_the_numericInputs_within_the_sliderInput_range_sets_proper_sliderInput_values
shinytest2-tm_g_gh_boxplot	💔	$15.22$	$+2.34$	toggle_slider_module_changing_the_sliderInput_sets_proper_numericInput_values
shinytest2-tm_g_gh_boxplot	💔	$13.79$	$+2.26$	toggle_slider_module_widgets_are_initialized_with_proper_values

Results for commit 32757ee

♻️ This comment has been updated with latest results.

[llrs-roche]

All examples could save and load the report. Good job!
Sorry for the late review!

Probably not addressable here but when rendering the reports for the examples when saving and loading a report I see:

Quitting from report.Rmd:58-60 [unnamed-chunk-5]
Render document error: Error in `gzfile()`:
! cannot open the connection

The lines where the unnamed chunk 5 is change depending on the module but it remains stable.
However, I could see the report loaded correctly.

[m7pr]

@llrs-roche this got fixed in herehttps://github.com/insightsengineering/teal.reporter/pull/385

[averissimo]

The reports look good 👍

I think this still needs some changes:

• teal.reporter version bump in DESCRIPTION
• use dimensions of image in browser to set reporter plot (1 comment, but applies to all)

There's a question about the constraints section that was completely removed.

[averissimo]

spaghettiplot is not working

All the others are great! 🥳

[m7pr]

spaghettiplot is not working

Hey, I hope you meant tm_g_gh_density_distribution_plot. I just fixed it and pushed the updates

[Copilot]

Pull Request Overview

This PR refactors the reporter functionality to support new teal_report and teal_card classes, replacing the legacy "Add to reporter" implementation. It systematically removes the old reporter UI buttons and server logic from all goshawk plot modules and introduces a new teal_reporter integration approach.

• Removes legacy reporter implementation across all plot modules
• Adds new utility functions for setting chunk attributes and dimensions on teal_card objects
• Updates modules to return teal_report objects with embedded plot cards and metadata

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.

File	Description
R/utils.R	Adds utility functions for managing teal_card attributes and plot dimensions
R/tm_g_gh_*.R	Refactors all plot modules to use new reporter system, removes legacy UI/server code
man/*.Rd	Updates documentation and removes legacy example code patterns
DESCRIPTION	Updates version dependencies for companion packages

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[averissimo]

Awesome!