Skip to content

Conversation

@gogonzo
Copy link
Contributor

@gogonzo gogonzo commented Oct 10, 2025

Followup after insightsengineering/teal#1623
TealAppDriver now accepts teal_app instead of data, modules, ...
Please run the tests with options(TESTING_DEPTH=5)

@gogonzo gogonzo added the core label Oct 10, 2025
@gogonzo gogonzo self-assigned this Oct 10, 2025
@github-actions
Copy link
Contributor

badge

Code Coverage Summary

Filename                                 Stmts    Miss  Cover    Missing
-------------------------------------  -------  ------  -------  -----------------------------------------------------
R/tm_g_gh_boxplot.R                        321      27  91.59%   355, 361, 511-518, 522-523, 531-546, 552-555
R/tm_g_gh_correlationplot.R                531     531  0.00%    229-863
R/tm_g_gh_density_distribution_plot.R      239     239  0.00%    140-425
R/tm_g_gh_lineplot.R                       514     514  0.00%    163-764
R/tm_g_gh_scatterplot.R                      5       5  0.00%    13-17
R/tm_g_gh_spaghettiplot.R                  291     291  0.00%    196-563
R/toggleable_slider.R                      112       7  93.75%   140-146
R/utils-arbitrary_lines.r                  121      14  88.43%   60, 71-74, 78, 90-93, 107, 111, 118, 122
R/utils-data_constraints.r                 189      53  71.96%   39, 57, 111-124, 126-140, 154, 175, 181, 200-226, 248
R/utils-maptrt.r                             9       9  0.00%    24-36
R/utils-templ_ui.r                          68      19  72.06%   2-9, 41-44, 74-80
R/utils.R                                   92      69  25.00%   5, 39-150, 180, 183-188
R/zzz.R                                      2       2  0.00%    2-3
TOTAL                                     2494    1780  28.63%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 14e6401

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2025

Unit Tests Summary

6 tests   0 ✅  3s ⏱️
1 suites  6 💤
1 files    0 ❌

Results for commit 14e6401.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2025

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
shinytest2-tm_g_gh_boxplot 💚 $115.85$ $-112.24$ $-3$ $+6$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
shinytest2-tm_g_gh_boxplot 💚 $14.83$ $-14.29$ toggle_slider_module_changing_dependant_widgets_outside_sets_proper_sliderInput_and_numericInput_values
shinytest2-tm_g_gh_boxplot 💚 $23.11$ $-22.57$ toggle_slider_module_changing_the_numericInputs_outside_the_sliderInput_range_sets_proper_sliderInput_values_and_range
shinytest2-tm_g_gh_boxplot 💚 $23.23$ $-22.57$ toggle_slider_module_changing_the_numericInputs_within_the_rage_sets_back_the_sliderInput_range_to_initial_range
shinytest2-tm_g_gh_boxplot 💚 $23.01$ $-22.45$ toggle_slider_module_changing_the_numericInputs_within_the_sliderInput_range_sets_proper_sliderInput_values
shinytest2-tm_g_gh_boxplot 💚 $16.48$ $-15.87$ toggle_slider_module_changing_the_sliderInput_sets_proper_numericInput_values
shinytest2-tm_g_gh_boxplot 💚 $15.20$ $-14.48$ toggle_slider_module_widgets_are_initialized_with_proper_values

Results for commit f2c84a7

♻️ This comment has been updated with latest results.

Copy link
Contributor

@m7pr m7pr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably the same as in tmg

> options(TESTING_DEPTH=5);devtools::test()
ℹ Testing teal.goshawk| F W  S  OK | Context|          0 | shinytest2-tm_g_gh_boxplot                                             [INFO] 2025-10-10 15:17:54.0153 pid:16096 token:[] teal.goshawk Initializing tm_g_gh_boxplot| 1        0 | shinytest2-tm_g_gh_boxplot                                             [INFO] 2025-10-10 15:17:54.7206 pid:16096 token:[] teal.goshawk Initializing tm_g_gh_boxplot| 2        0 | shinytest2-tm_g_gh_boxplot                                             [INFO] 2025-10-10 15:17:55.3297 pid:16096 token:[] teal.goshawk Initializing tm_g_gh_boxplot| 3        0 | shinytest2-tm_g_gh_boxplot                                             [INFO] 2025-10-10 15:17:55.9445 pid:16096 token:[] teal.goshawk Initializing tm_g_gh_boxplot| 4        0 | shinytest2-tm_g_gh_boxplot                                             [INFO] 2025-10-10 15:17:56.7767 pid:16096 token:[] teal.goshawk Initializing tm_g_gh_boxplot| 5        0 | shinytest2-tm_g_gh_boxplot                                             [INFO] 2025-10-10 15:17:57.3295 pid:16096 token:[] teal.goshawk Initializing tm_g_gh_boxplot| 6        0 | shinytest2-tm_g_gh_boxplot [4.9s]                                      
────────────────────────────────────────────────────────────────────────────────────────
Error (test-shinytest2-tm_g_gh_boxplot.R:25:3): toggle_slider_module: widgets are initialized with proper values
<evalError/missingArgError/error/condition>
Error in `initialize(...)`: argument "modules" is missing, with no default
Backtrace:1. └─teal.goshawk (local) tm_g_gh_boxplot_driver() at test-shinytest2-tm_g_gh_boxplot.R:25:3
 2.   └─init_teal_app_driver(...) at test-shinytest2-tm_g_gh_boxplot.R:2:3
 3.     ├─testthat::with_mocked_bindings(...) at C:\Rprojects\teal.goshawk\tests\testthat\helper-TealAppDriver.R:2:3
 4.     └─TealAppDriver$new(teal::init(...)) at C:\Rprojects\teal.goshawk\tests\testthat\helper-TealAppDriver.R:5:7
 5.       └─teal (local) initialize(...)

Error (test-shinytest2-tm_g_gh_boxplot.R:38:3): toggle_slider_module: changing the sliderInput sets proper numericInput values
<evalError/missingArgError/error/condition>
Error in `initialize(...)`: argument "modules" is missing, with no default
Backtrace:1. └─teal.goshawk (local) tm_g_gh_boxplot_driver() at test-shinytest2-tm_g_gh_boxplot.R:38:3
 2.   └─init_teal_app_driver(...) at test-shinytest2-tm_g_gh_boxplot.R:2:3
 3.     ├─testthat::with_mocked_bindings(...) at C:\Rprojects\teal.goshawk\tests\testthat\helper-TealAppDriver.R:2:3
 4.     └─TealAppDriver$new(teal::init(...)) at C:\Rprojects\teal.goshawk\tests\testthat\helper-TealAppDriver.R:5:7
 5.       └─teal (local) initialize(...)

Error (test-shinytest2-tm_g_gh_boxplot.R:54:5): toggle_slider_module: changing the numericInputs
  within the sliderInput range, sets proper sliderInput values
<evalError/missingArgError/error/condition>
Error in `initialize(...)`: argument "modules" is missing, with no default
Backtrace:1. └─teal.goshawk (local) tm_g_gh_boxplot_driver() at test-shinytest2-tm_g_gh_boxplot.R:54:5
 2.   └─init_teal_app_driver(...) at test-shinytest2-tm_g_gh_boxplot.R:2:3
 3.     ├─testthat::with_mocked_bindings(...) at C:\Rprojects\teal.goshawk\tests\testthat\helper-TealAppDriver.R:2:3
 4.     └─TealAppDriver$new(teal::init(...)) at C:\Rprojects\teal.goshawk\tests\testthat\helper-TealAppDriver.R:5:7
 5.       └─teal (local) initialize(...)

Error (test-shinytest2-tm_g_gh_boxplot.R:88:5): toggle_slider_module: changing the numericInputs
  outside the sliderInput range, sets proper sliderInput values and range
<evalError/missingArgError/error/condition>
Error in `initialize(...)`: argument "modules" is missing, with no default
Backtrace:1. └─teal.goshawk (local) tm_g_gh_boxplot_driver() at test-shinytest2-tm_g_gh_boxplot.R:88:5
 2.   └─init_teal_app_driver(...) at test-shinytest2-tm_g_gh_boxplot.R:2:3
 3.     ├─testthat::with_mocked_bindings(...) at C:\Rprojects\teal.goshawk\tests\testthat\helper-TealAppDriver.R:2:3
 4.     └─TealAppDriver$new(teal::init(...)) at C:\Rprojects\teal.goshawk\tests\testthat\helper-TealAppDriver.R:5:7
 5.       └─teal (local) initialize(...)

Error (test-shinytest2-tm_g_gh_boxplot.R:121:5): toggle_slider_module: changing the numericInputs
  within the rage, sets back the sliderInput range to initial range
<evalError/missingArgError/error/condition>
Error in `initialize(...)`: argument "modules" is missing, with no default
Backtrace:1. └─teal.goshawk (local) tm_g_gh_boxplot_driver() at test-shinytest2-tm_g_gh_boxplot.R:121:5
 2.   └─init_teal_app_driver(...) at test-shinytest2-tm_g_gh_boxplot.R:2:3
 3.     ├─testthat::with_mocked_bindings(...) at C:\Rprojects\teal.goshawk\tests\testthat\helper-TealAppDriver.R:2:3
 4.     └─TealAppDriver$new(teal::init(...)) at C:\Rprojects\teal.goshawk\tests\testthat\helper-TealAppDriver.R:5:7
 5.       └─teal (local) initialize(...)

Error (test-shinytest2-tm_g_gh_boxplot.R:155:5): toggle_slider_module: changing dependant widgets outside
sets proper sliderInput and numericInput values
<evalError/missingArgError/error/condition>
Error in `initialize(...)`: argument "modules" is missing, with no default
Backtrace:1. └─teal.goshawk (local) tm_g_gh_boxplot_driver() at test-shinytest2-tm_g_gh_boxplot.R:155:5
 2.   └─init_teal_app_driver(...) at test-shinytest2-tm_g_gh_boxplot.R:2:3
 3.     ├─testthat::with_mocked_bindings(...) at C:\Rprojects\teal.goshawk\tests\testthat\helper-TealAppDriver.R:2:3
 4.     └─TealAppDriver$new(teal::init(...)) at C:\Rprojects\teal.goshawk\tests\testthat\helper-TealAppDriver.R:5:7
 5.       └─teal (local) initialize(...)
────────────────────────────────────────────────────────────────────────────────────────

══ Results ═════════════════════════════════════════════════════════════════════════════
Duration: 5.2 s

── Failed tests ────────────────────────────────────────────────────────────────────────
Error (test-shinytest2-tm_g_gh_boxplot.R:25:3): toggle_slider_module: widgets are initialized with proper values
<evalError/missingArgError/error/condition>
Error in `initialize(...)`: argument "modules" is missing, with no default
Backtrace:1. └─teal.goshawk (local) tm_g_gh_boxplot_driver() at test-shinytest2-tm_g_gh_boxplot.R:25:3
 2.   └─init_teal_app_driver(...) at test-shinytest2-tm_g_gh_boxplot.R:2:3
 3.     ├─testthat::with_mocked_bindings(...) at C:\Rprojects\teal.goshawk\tests\testthat\helper-TealAppDriver.R:2:3
 4.     └─TealAppDriver$new(teal::init(...)) at C:\Rprojects\teal.goshawk\tests\testthat\helper-TealAppDriver.R:5:7
 5.       └─teal (local) initialize(...)

Error (test-shinytest2-tm_g_gh_boxplot.R:38:3): toggle_slider_module: changing the sliderInput sets proper numericInput values
<evalError/missingArgError/error/condition>
Error in `initialize(...)`: argument "modules" is missing, with no default
Backtrace:1. └─teal.goshawk (local) tm_g_gh_boxplot_driver() at test-shinytest2-tm_g_gh_boxplot.R:38:3
 2.   └─init_teal_app_driver(...) at test-shinytest2-tm_g_gh_boxplot.R:2:3
 3.     ├─testthat::with_mocked_bindings(...) at C:\Rprojects\teal.goshawk\tests\testthat\helper-TealAppDriver.R:2:3
 4.     └─TealAppDriver$new(teal::init(...)) at C:\Rprojects\teal.goshawk\tests\testthat\helper-TealAppDriver.R:5:7
 5.       └─teal (local) initialize(...)

Error (test-shinytest2-tm_g_gh_boxplot.R:54:5): toggle_slider_module: changing the numericInputs
  within the sliderInput range, sets proper sliderInput values
<evalError/missingArgError/error/condition>
Error in `initialize(...)`: argument "modules" is missing, with no default
Backtrace:1. └─teal.goshawk (local) tm_g_gh_boxplot_driver() at test-shinytest2-tm_g_gh_boxplot.R:54:5
 2.   └─init_teal_app_driver(...) at test-shinytest2-tm_g_gh_boxplot.R:2:3
 3.     ├─testthat::with_mocked_bindings(...) at C:\Rprojects\teal.goshawk\tests\testthat\helper-TealAppDriver.R:2:3
 4.     └─TealAppDriver$new(teal::init(...)) at C:\Rprojects\teal.goshawk\tests\testthat\helper-TealAppDriver.R:5:7
 5.       └─teal (local) initialize(...)

Error (test-shinytest2-tm_g_gh_boxplot.R:88:5): toggle_slider_module: changing the numericInputs
  outside the sliderInput range, sets proper sliderInput values and range
<evalError/missingArgError/error/condition>
Error in `initialize(...)`: argument "modules" is missing, with no default
Backtrace:1. └─teal.goshawk (local) tm_g_gh_boxplot_driver() at test-shinytest2-tm_g_gh_boxplot.R:88:5
 2.   └─init_teal_app_driver(...) at test-shinytest2-tm_g_gh_boxplot.R:2:3
 3.     ├─testthat::with_mocked_bindings(...) at C:\Rprojects\teal.goshawk\tests\testthat\helper-TealAppDriver.R:2:3
 4.     └─TealAppDriver$new(teal::init(...)) at C:\Rprojects\teal.goshawk\tests\testthat\helper-TealAppDriver.R:5:7
 5.       └─teal (local) initialize(...)

Error (test-shinytest2-tm_g_gh_boxplot.R:121:5): toggle_slider_module: changing the numericInputs
  within the rage, sets back the sliderInput range to initial range
<evalError/missingArgError/error/condition>
Error in `initialize(...)`: argument "modules" is missing, with no default
Backtrace:1. └─teal.goshawk (local) tm_g_gh_boxplot_driver() at test-shinytest2-tm_g_gh_boxplot.R:121:5
 2.   └─init_teal_app_driver(...) at test-shinytest2-tm_g_gh_boxplot.R:2:3
 3.     ├─testthat::with_mocked_bindings(...) at C:\Rprojects\teal.goshawk\tests\testthat\helper-TealAppDriver.R:2:3
 4.     └─TealAppDriver$new(teal::init(...)) at C:\Rprojects\teal.goshawk\tests\testthat\helper-TealAppDriver.R:5:7
 5.       └─teal (local) initialize(...)

Error (test-shinytest2-tm_g_gh_boxplot.R:155:5): toggle_slider_module: changing dependant widgets outside
sets proper sliderInput and numericInput values
<evalError/missingArgError/error/condition>
Error in `initialize(...)`: argument "modules" is missing, with no default
Backtrace:1. └─teal.goshawk (local) tm_g_gh_boxplot_driver() at test-shinytest2-tm_g_gh_boxplot.R:155:5
 2.   └─init_teal_app_driver(...) at test-shinytest2-tm_g_gh_boxplot.R:2:3
 3.     ├─testthat::with_mocked_bindings(...) at C:\Rprojects\teal.goshawk\tests\testthat\helper-TealAppDriver.R:2:3
 4.     └─TealAppDriver$new(teal::init(...)) at C:\Rprojects\teal.goshawk\tests\testthat\helper-TealAppDriver.R:5:7
 5.       └─teal (local) initialize(...)

[ FAIL 6 | WARN 0 | SKIP 0 | PASS 0 ]

Copy link
Contributor

@m7pr m7pr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all checks have passed

@m7pr m7pr merged commit 6022036 into main Oct 17, 2025
26 checks passed
@m7pr m7pr deleted the TealAppDriver_changes branch October 17, 2025 12:43
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants