Skip to content

Duplicated decorators during an edge case of named and unnamed decorators #1325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 7, 2025
Merged

Duplicated decorators during an edge case of named and unnamed decorators #1325

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2cd2e57
deal with an example where some decorators are named and some are unn…
m7pr Jan 28, 2025
95e75c3
Merge branch 'main' into 1316_duplicates@main
m7pr Jan 29, 2025
ed015aa
allow either all named or all unnamed decorators
m7pr Jan 31, 2025
9caafdf
Merge branch 'main' into 1316_duplicates@main
m7pr Jan 31, 2025
af0f09e
when non-unique names are passed to decorators, throw a warning from …
m7pr Feb 6, 2025
ca761ee
Merge branch 'main' into 1316_duplicates@main
m7pr Feb 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions R/utils.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1076,10 +1076,15 @@ select_decorators <- function(decorators, scope) {
#' @keywords internal
normalize_decorators <- function(decorators) {
if (checkmate::test_list(decorators, "teal_transform_module")) {
if (checkmate::test_names(names(decorators))) {
decorators_names <- names(decorators)[!names(decorators) %in% ""]
# Above is equivalent to decorators_names <- setdiff(names(decorators), "")
# but can return non-unique values. Non-unique values are checked in assert_decorators.
if (length(decorators_names) == 0) {
list(default = decorators)
} else if (length(decorators_names) == length(decorators)) {
lapply(decorators, list)
} else {
list(default = decorators)
stop("All decorators should either be named or unnamed.")
}
} else {
decorators
Expand Down