Skip to content

Test fast checking when general R file is modified #1339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

Test fast checking when general R file is modified #1339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
37bfd44
Modify utils
llrs-roche Feb 5, 2025
c116665
Use branch to test ci step
llrs-roche Feb 6, 2025
ac3b61a
Merged origin/main into test_ci_utils
llrs-roche Feb 10, 2025
8eb1a94
Update SHA
llrs-roche Feb 10, 2025
167f7a0
Forgot to activate them
llrs-roche Feb 10, 2025
955c62d
Update latest sha
llrs-roche Feb 10, 2025
7967337
Missed one fast-tests
llrs-roche Feb 10, 2025
ab5ae25
Not needed at all...
llrs-roche Feb 10, 2025
1c8b8ad
update sha
llrs-roche Feb 11, 2025
1dc5659
update sha
llrs-roche Feb 11, 2025
9451295
update sha
llrs-roche Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/check.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
uses: insightsengineering/r.pkg.template/.github/workflows/audit.yaml@main
r-cmd:
name: R CMD Check 🧬
uses: insightsengineering/r.pkg.template/.github/workflows/build-check-install.yaml@main
uses: insightsengineering/r.pkg.template/.github/workflows/build-check-install.yaml@e391bb2ba6d0b1318773ff2f4dbb6c0eeaabcece
secrets:
REPO_GITHUB_TOKEN: ${{ secrets.REPO_GITHUB_TOKEN }}
with:
Expand All @@ -42,9 +42,10 @@ jobs:
unit-test-report-brand: >-
https://raw.githubusercontent.com/insightsengineering/hex-stickers/main/thumbs/teal.png
deps-installation-method: setup-r-dependencies
selected-shinytests: true
r-cmd-non-cran:
name: R CMD Check (non-CRAN) 🧬
uses: insightsengineering/r.pkg.template/.github/workflows/build-check-install.yaml@main
uses: insightsengineering/r.pkg.template/.github/workflows/build-check-install.yaml@e391bb2ba6d0b1318773ff2f4dbb6c0eeaabcece
secrets:
REPO_GITHUB_TOKEN: ${{ secrets.REPO_GITHUB_TOKEN }}
with:
Expand All @@ -63,6 +64,7 @@ jobs:
checking for unstated dependencies in vignettes .* NOTE
checking top-level files .* NOTE
deps-installation-method: setup-r-dependencies
selected-shinytests: true
coverage:
name: Coverage 📔
uses: insightsengineering/r.pkg.template/.github/workflows/test-coverage.yaml@main
Expand Down
2 changes: 1 addition & 1 deletion R/utils.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -567,7 +567,7 @@ prepare_arm <- function(dataname,
checkmate::assert_flag(compare_arm)
checkmate::assert_string(ref_arm_val)
checkmate::assert_flag(drop)

message("Utils prepare_arm function is modified")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dummy message to modify an R/*.R file not related to a module.
Opening this issue to prevent merging the PR by accident

data_list <- list()

if (compare_arm) {
Expand Down
Loading