Skip to content

Conversation

@m7pr
Copy link
Contributor

@m7pr m7pr commented Oct 13, 2025

@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2025

Unit Tests Summary

  1 files   71 suites   11s ⏱️
734 tests 155 ✅ 579 💤 0 ❌
874 runs  176 ✅ 698 💤 0 ❌

Results for commit e96db94.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2025

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
examples 💚 $6.90$ $-5.24$ $0$ $+115$ $0$ $0$
tm_t_glm_counts 💚 $24.73$ $-24.52$ $-3$ $0$ $0$ $+2$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
tm_t_glm_counts 💚 $12.24$ $-12.11$ e2e_tm_t_glm_counts_Module_initializes_in_teal_without_errors_and_produces_table_output.
tm_t_glm_counts 💚 $12.49$ $-12.41$ e2e_tm_t_glm_counts_Selecting_arm_var_changes_the_table_and_does_not_throw_validation_errors.

Results for commit 5af1202

♻️ This comment has been updated with latest results.

Copy link
Contributor

@llrs-roche llrs-roche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple change. Looks good.

Locally some examples fail (6) but I don't expect this to be related to this change. There are also some other failures with checkmate::assert_class(app, "teal_app"): argument "app" is missing, with no default, as reported by the CI. I've seen that error message before but I am not sure what I did to fix it.

@m7pr m7pr enabled auto-merge (squash) October 14, 2025 12:48
@m7pr
Copy link
Contributor Author

m7pr commented Oct 14, 2025

@llrs-roche tests are failiing becuase we changed TealAppDriver in teal and in tmg, but not anywhere else

@m7pr
Copy link
Contributor Author

m7pr commented Oct 14, 2025

Oh, but the PR for teal changes in TealAppDriver is not yet merged insightsengineering/teal#1633
So I think we need to wait for it

m7pr added a commit to insightsengineering/teal.reporter that referenced this pull request Oct 14, 2025
Fixes
-
insightsengineering/teal.modules.clinical#1427

Now, when concatenating `teal_report` or `teal_card` you are able to
hide a below warning

```r
Appended `teal_card` doesn't remove some of the elements from previous `teal_card`.
Restoring original content and adding only new items to the end of the card.
```

if objects share same elements of `teal_card` elements.

Respective PR in `teal.modules.clinical` that fixes one module
- insightsengineering/teal.modules.clinical#1431

Alternatively we can just use `suppressWarnings` when applying `c` on
two `teal_report` object that share the same base of `teal_card`.

---------

Signed-off-by: Marcin <[email protected]>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Lluís Revilla <[email protected]>
@m7pr m7pr merged commit 99c2457 into main Oct 17, 2025
21 checks passed
@m7pr m7pr deleted the verbose_c branch October 17, 2025 11:15
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants