-
-
Notifications
You must be signed in to change notification settings - Fork 19
remove warning on concatention in tm_g_pp_adverse_events
#1431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Unit Tests Summary 1 files 71 suites 11s ⏱️ Results for commit e96db94. ♻️ This comment has been updated with latest results. |
Unit Test Performance Difference
Additional test case details
Results for commit 5af1202 ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simple change. Looks good.
Locally some examples fail (6) but I don't expect this to be related to this change. There are also some other failures with checkmate::assert_class(app, "teal_app"): argument "app" is missing, with no default, as reported by the CI. I've seen that error message before but I am not sure what I did to fix it.
|
@llrs-roche tests are failiing becuase we changed |
|
Oh, but the PR for teal changes in TealAppDriver is not yet merged insightsengineering/teal#1633 |
Fixes - insightsengineering/teal.modules.clinical#1427 Now, when concatenating `teal_report` or `teal_card` you are able to hide a below warning ```r Appended `teal_card` doesn't remove some of the elements from previous `teal_card`. Restoring original content and adding only new items to the end of the card. ``` if objects share same elements of `teal_card` elements. Respective PR in `teal.modules.clinical` that fixes one module - insightsengineering/teal.modules.clinical#1431 Alternatively we can just use `suppressWarnings` when applying `c` on two `teal_report` object that share the same base of `teal_card`. --------- Signed-off-by: Marcin <[email protected]> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Lluís Revilla <[email protected]>
Part of
verbosetoc.teal_reportandc.teal_cardteal.reporter#421Fixes
tm_g_pp_adverse_events#1427