-
-
Notifications
You must be signed in to change notification settings - Fork 19
Fixes plot settings that did not have an accordion wrapper #1436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Unit Tests Summary 1 files 71 suites 41s ⏱️ Results for commit d7778d3. ♻️ This comment has been updated with latest results. |
Unit Test Performance Difference
Additional test case details
Results for commit 14c9c6e ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look ok. I will review the modules in teal apps to verify they look ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a UI structure issue where plot and table settings panels were missing proper bslib::accordion wrappers. The changes ensure consistent accordion panel structure across multiple modules by wrapping bslib::accordion_panel elements with parent bslib::accordion containers and moving the open = TRUE parameter from the panel to the accordion level.
- Adds
bslib::accordionwrapper around existingbslib::accordion_panelelements - Moves
open = TRUEparameter from panel level to accordion level - Restructures one table settings component to use
tagListwrapper
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| R/tm_t_tte.R | Wraps "Additional table settings" panel with accordion and fixes formatting |
| R/tm_t_glm_counts.R | Restructures table settings with tagList and accordion wrapper |
| R/tm_t_events.R | Wraps "Additional table settings" panel with accordion |
| R/tm_t_binary_outcome.R | Wraps "Additional table settings" panel with accordion |
| R/tm_g_pp_vitals.R | Wraps "Plot settings" panel with accordion |
| R/tm_g_pp_therapy.R | Wraps "Plot settings" panel with accordion |
| R/tm_g_pp_patient_timeline.R | Wraps "Plot settings" panel with accordion |
| R/tm_g_pp_adverse_events.R | Wraps "Plot settings" panel with accordion |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've checked all modules in teal.gallery apps except tm_t_glm_counts that is not used.
With the changes, is looking much better.
When all changes are done, we need to update the teal.gallery dependencies
Pull Request
Companion PR:
Note to reviewer
ℹ️ Please check each example app of the affected module
Changes description
bslib::accordionwrapper to plot settings that were missing