-
-
Notifications
You must be signed in to change notification settings - Fork 19
Update UI selectors for tm_t_summary #1442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
In the last commit I activated the checks on all PR independently of which branch they come from. This should make CI easier for later when we merge |
Unit Test Performance DifferenceTest suite performance difference
Results for commit 2392d05 ♻️ This comment has been updated with latest results. |
osenan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good changes! I run the test locally and they work!
I will implement this kind of changes in my fixes, as they are better.
Pull Request
Part of #1440
This was after a discussion to use the shorter selector for the UI of the modules
Test the two modules affected with
devtools::test(filter = "tm_t_summary").Short selectors used operators as found on https://www.w3schools.com/cssref/css_selectors.php