Skip to content

Conversation

@llrs-roche
Copy link
Contributor

@llrs-roche llrs-roche commented Nov 24, 2025

Pull Request

Part of #1440

This was after a discussion to use the shorter selector for the UI of the modules

Test the two modules affected with devtools::test(filter = "tm_t_summary").

Short selectors used operators as found on https://www.w3schools.com/cssref/css_selectors.php

@llrs-roche
Copy link
Contributor Author

In the last commit I activated the checks on all PR independently of which branch they come from. This should make CI easier for later when we merge bring_test to main

@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2025

Unit Tests Summary

  1 files  ±0   71 suites  ±0   1m 23s ⏱️ -1s
734 tests ±0  155 ✅ ±0  579 💤 ±0  0 ❌ ±0 
874 runs  ±0  176 ✅ ±0  698 💤 ±0  0 ❌ ±0 

Results for commit b5b7af2. ± Comparison against base commit d200e5f.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2025

Unit Test Performance Difference

Test suite performance difference
Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
shinytest2-tm_a_gee 💔 $0.23$ $+3.77$ $0$ $0$ $0$ $0$
shinytest2-tm_a_mmrm 💔 $0.66$ $+7.93$ $0$ $0$ $0$ $0$
shinytest2-tm_g_barchart_simple 💔 $0.33$ $+2.71$ $0$ $0$ $0$ $0$
shinytest2-tm_g_ci 💔 $0.20$ $+1.16$ $0$ $0$ $0$ $0$
shinytest2-tm_g_forest_rsp 💔 $0.25$ $+2.68$ $0$ $0$ $0$ $0$
shinytest2-tm_g_ipp 💔 $0.19$ $+2.73$ $0$ $0$ $0$ $0$
shinytest2-tm_g_km 💔 $0.38$ $+3.12$ $0$ $0$ $0$ $0$
shinytest2-tm_g_lineplot 💔 $0.14$ $+1.12$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_adverse_events 💔 $0.25$ $+1.94$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_patient_timeline 💔 $0.37$ $+5.06$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_therapy 💔 $0.33$ $+7.01$ $0$ $0$ $0$ $0$
shinytest2-tm_t_abnormality 💔 $0.13$ $+1.17$ $0$ $0$ $0$ $0$
shinytest2-tm_t_abnormality_by_worst_grade 💔 $0.12$ $+1.36$ $0$ $0$ $0$ $0$
shinytest2-tm_t_ancova 💔 $0.37$ $+2.13$ $0$ $0$ $0$ $0$
shinytest2-tm_t_binary_outcome 💔 $0.14$ $+1.46$ $0$ $0$ $0$ $0$
shinytest2-tm_t_coxreg 💔 $0.17$ $+1.03$ $0$ $0$ $0$ $0$
shinytest2-tm_t_events_by_grade 💔 $0.13$ $+1.55$ $0$ $0$ $0$ $0$
shinytest2-tm_t_events_summary 💔 $0.11$ $+2.48$ $0$ $0$ $0$ $0$
shinytest2-tm_t_exposure 💔 $0.13$ $+3.03$ $0$ $0$ $0$ $0$
shinytest2-tm_t_pp_laboratory 💔 $0.22$ $+1.44$ $0$ $0$ $0$ $0$
shinytest2-tm_t_pp_prior_medication 💔 $0.16$ $+1.48$ $0$ $0$ $0$ $0$
shinytest2-tm_t_shift_by_arm 💔 $0.11$ $+1.26$ $0$ $0$ $0$ $0$
shinytest2-tm_t_shift_by_arm_by_worst 💔 $0.17$ $+1.91$ $0$ $0$ $0$ $0$
shinytest2-tm_t_shift_by_grade 💔 $0.13$ $+1.84$ $0$ $0$ $0$ $0$
shinytest2-tm_t_smq 💔 $0.11$ $+1.24$ $0$ $0$ $0$ $0$
shinytest2-tm_t_summary_by 💔 $0.15$ $+1.52$ $0$ $0$ $0$ $0$

Results for commit 2392d05

♻️ This comment has been updated with latest results.

llrs-roche added a commit that referenced this pull request Nov 25, 2025
# Pull Request

Fixes #1440 
Companion of #1441 


Test with `devtools::test(filter = "tm_t_shift_by")`

Note that here the tests use the class of the elements instead of the id
of the elements like in other PR (#1443, #1442 )
@llrs-roche llrs-roche changed the title Update UI selectors Update UI selectors for tm_t_summary Nov 26, 2025
Copy link

@osenan osenan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good changes! I run the test locally and they work!
I will implement this kind of changes in my fixes, as they are better.

@osenan osenan self-assigned this Nov 26, 2025
@llrs-roche llrs-roche merged commit 4d003c2 into bring_tests Nov 26, 2025
9 of 20 checks passed
@llrs-roche llrs-roche deleted the tm_t_summary branch November 26, 2025 15:44
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants