Skip to content

Conversation

@osenan
Copy link

@osenan osenan commented Nov 25, 2025

Pull Request

Part of #1440
Companion #1441

While reviewing this PR I found that one e2e test on the edited files was failing.
The fix was simple, I was working on a similar fix for g_pp modules.

Please test it with devtools::test(filter = "tm_t_shift_by")

@osenan osenan requested a review from llrs-roche November 25, 2025 14:21
@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2025


🎉 Thank you for your contribution! Before this PR can be accepted, we require that you read and agree to our Contributor License Agreement.
You can digitally sign the CLA by posting a comment on this Pull Request in the format shown below. This agreement will apply to this PR as well as all future contributions on this repository.


I have read the CLA Document and I hereby sign the CLA


osenan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@github-actions
Copy link
Contributor

Unit Tests Summary

  1 files  ±0   71 suites  ±0   1m 21s ⏱️ -1s
734 tests ±0  155 ✅ ±0  579 💤 ±0  0 ❌ ±0 
874 runs  ±0  176 ✅ ±0  698 💤 ±0  0 ❌ ±0 

Results for commit fea280d. ± Comparison against base commit d200e5f.

@github-actions
Copy link
Contributor

Unit Test Performance Difference

Test suite performance difference
Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
shinytest2-tm_a_gee 💔 $0.23$ $+3.43$ $0$ $0$ $0$ $0$
shinytest2-tm_a_mmrm 💔 $0.66$ $+7.47$ $0$ $0$ $0$ $0$
shinytest2-tm_g_barchart_simple 💔 $0.33$ $+2.58$ $0$ $0$ $0$ $0$
shinytest2-tm_g_ci 💔 $0.20$ $+1.12$ $0$ $0$ $0$ $0$
shinytest2-tm_g_forest_rsp 💔 $0.25$ $+2.58$ $0$ $0$ $0$ $0$
shinytest2-tm_g_ipp 💔 $0.19$ $+2.69$ $0$ $0$ $0$ $0$
shinytest2-tm_g_km 💔 $0.38$ $+3.03$ $0$ $0$ $0$ $0$
shinytest2-tm_g_lineplot 💔 $0.14$ $+1.06$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_adverse_events 💔 $0.25$ $+1.82$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_patient_timeline 💔 $0.37$ $+4.64$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_therapy 💔 $0.33$ $+7.04$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_vitals 💔 $0.16$ $+1.19$ $0$ $0$ $0$ $0$
shinytest2-tm_t_abnormality 💔 $0.13$ $+1.11$ $0$ $0$ $0$ $0$
shinytest2-tm_t_abnormality_by_worst_grade 💔 $0.12$ $+1.30$ $0$ $0$ $0$ $0$
shinytest2-tm_t_ancova 💔 $0.37$ $+1.98$ $0$ $0$ $0$ $0$
shinytest2-tm_t_binary_outcome 💔 $0.14$ $+1.36$ $0$ $0$ $0$ $0$
shinytest2-tm_t_events_by_grade 💔 $0.13$ $+1.44$ $0$ $0$ $0$ $0$
shinytest2-tm_t_events_summary 💔 $0.11$ $+2.37$ $0$ $0$ $0$ $0$
shinytest2-tm_t_exposure 💔 $0.13$ $+3.01$ $0$ $0$ $0$ $0$
shinytest2-tm_t_pp_laboratory 💔 $0.22$ $+1.43$ $0$ $0$ $0$ $0$
shinytest2-tm_t_pp_prior_medication 💔 $0.16$ $+1.49$ $0$ $0$ $0$ $0$
shinytest2-tm_t_shift_by_arm 💔 $0.11$ $+1.27$ $0$ $0$ $0$ $0$
shinytest2-tm_t_shift_by_arm_by_worst 💔 $0.17$ $+1.88$ $0$ $0$ $0$ $0$
shinytest2-tm_t_shift_by_grade 💔 $0.13$ $+1.88$ $0$ $0$ $0$ $0$
shinytest2-tm_t_smq 💔 $0.11$ $+1.24$ $0$ $0$ $0$ $0$
shinytest2-tm_t_summary_by 💔 $0.15$ $+1.48$ $0$ $0$ $0$ $0$

Results for commit 74bf64e

♻️ This comment has been updated with latest results.

@osenan
Copy link
Author

osenan commented Nov 25, 2025

I have read the CLA Document and I hereby sign the CLA

@llrs-roche llrs-roche self-assigned this Nov 25, 2025
@llrs-roche
Copy link
Contributor

Copy link
Contributor

@llrs-roche llrs-roche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update this and merge

refactor: use more general selector

Co-authored-by: Lluís Revilla <[email protected]>
Signed-off-by: Oriol Senan  <[email protected]>
@osenan osenan merged commit 40b5489 into bring_tests Nov 27, 2025
10 of 20 checks passed
@osenan osenan deleted the fix-tm_shift_by_grade@bring_tests branch November 27, 2025 02:21
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants