-
-
Notifications
You must be signed in to change notification settings - Fork 19
Fix one selector in tm_shift_by_grade #1445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I have read the CLA Document and I hereby sign the CLA osenan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
Unit Test Performance DifferenceTest suite performance difference
Results for commit 74bf64e ♻️ This comment has been updated with latest results. |
|
I have read the CLA Document and I hereby sign the CLA |
|
Sorry I mixed PR and that one was merged by accident. Use this selector instead: https://github.com/insightsengineering/teal.modules.clinical/pull/1441/files#diff-eea16ad04c22c49466b528d79edebfcb683d3f6f2a255581e007bcc8534c9e9cR65 |
llrs-roche
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update this and merge
refactor: use more general selector Co-authored-by: Lluís Revilla <[email protected]> Signed-off-by: Oriol Senan <[email protected]>
Pull Request
Part of #1440
Companion #1441
While reviewing this PR I found that one e2e test on the edited files was failing.
The fix was simple, I was working on a similar fix for
g_ppmodules.Please test it with
devtools::test(filter = "tm_t_shift_by")