Skip to content

Conversation

@m7pr
Copy link
Contributor

@m7pr m7pr commented Jan 21, 2025

The same as in tmc
insightsengineering/teal.modules.clinical@b048f37
do not allow decorators with duplicated names

@m7pr m7pr added the core label Jan 21, 2025
@m7pr m7pr requested a review from llrs-roche January 21, 2025 10:01
@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2025

Unit Tests Summary

  1 files   22 suites   13m 1s ⏱️
145 tests 107 ✅ 38 💤 0 ❌
476 runs  438 ✅ 38 💤 0 ❌

Results for commit 18cf80e.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2025

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
shinytest2-tm_g_scatterplot 💚 $74.21$ $-1.00$ $0$ $0$ $0$ $0$
shinytest2-tm_g_scatterplotmatrix 💔 $27.22$ $+1.22$ $0$ $0$ $0$ $0$
shinytest2-tm_misssing_data 💔 $47.64$ $+1.26$ $0$ $0$ $0$ $0$

Results for commit 17c9c41

♻️ This comment has been updated with latest results.

@llrs-roche llrs-roche self-assigned this Jan 21, 2025
Copy link
Contributor

@llrs-roche llrs-roche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there are duplicated decorators and decorators that won't be used by the module only the first issue will be raised.

@m7pr
Copy link
Contributor Author

m7pr commented Jan 22, 2025

@llrs-roche Just sent the same fix as in here

@m7pr m7pr merged commit d01a47f into main Jan 22, 2025
26 checks passed
@m7pr m7pr deleted the 1441_nonunique_decorators@main branch January 22, 2025 12:12
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants