Skip to content

add a check for non-unique decorator names #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 22, 2025
Merged

add a check for non-unique decorator names #828

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e6b3ff2
add a check for non-unique decorator names
m7pr Jan 21, 2025
5576f60
stack deorators messages
m7pr Jan 22, 2025
cbca67f
[skip style] [skip vbump] Restyle files
github-actions[bot] Jan 22, 2025
6a4350c
use double quotes
m7pr Jan 22, 2025
18cf80e
Merge branch '1441_nonunique_decorators@main' of https://github.com/i…
m7pr Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions R/utils.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,6 +350,9 @@ check_decorators <- function(x, names = NULL) { # nolint: object_name.
check_message <- if (isTRUE(check_message)) {
out_message <- checkmate::check_names(names(x), subset.of = c("default", names))
# see https://github.com/insightsengineering/teal.logger/issues/101
if (length(names(x)) != length(unique(names(x)))) {
out_message <- "Non-unique names in decorators."
}
if (isTRUE(out_message)) {
out_message
} else {
Expand Down
Loading