-
-
Notifications
You must be signed in to change notification settings - Fork 15
introduce decorators for tm_data_table
#799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduce decorators for tm_data_table
#799
Conversation
…ou see error from original teal_data
tm_data_tabletm_data_table
|
Hey @averissimo this PR is done, however I would need some extra pair of 👁️ eyes. This example for for non-ineractive decorator. However it fails for interactive decorator because inside the Would you maybe be able to take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Show R code is not working and there will be a linter error
Co-authored-by: André Veríssimo <[email protected]> Signed-off-by: Marcin <[email protected]>
|
The **CURRENT** implementation of data-table has for each of the datanames:
Q: Do we want to try and create a "singleton" UI that then applies to each one dataname?In practice: Do we want to have a single UI for options applied to each dataname, or a UI for each of the datanames (as is now) Consequences: We need get inputs from 1-level above as the Current implementation vs. Qedit: note that every sub-box is a tab in the module. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉

Part of #863
Working Example