Skip to content

Conversation

@llrs-roche
Copy link
Contributor

Pull Request

Fixes #813

On #814 we only addressed the missing dependency (the first two code blocks), on this PR the issues with the links (the third code block).

R CMD check doesn't complain (with 2024-12-07 r87428 ucrt).

See insightsengineering/teal#1420 (comment) for a longer explanation on why this fixed the links issue.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 11, 2024

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  -------------------------------------------------
R/tm_a_pca.R                    884     884  0.00%    138-1155
R/tm_a_regression.R             772     772  0.00%    162-1036
R/tm_data_table.R               215     215  0.00%    110-380
R/tm_file_viewer.R              173     173  0.00%    47-255
R/tm_front_page.R               133     122  8.27%    73-231
R/tm_g_association.R            340     340  0.00%    143-556
R/tm_g_bivariate.R              685     421  38.54%   315-794, 835, 946, 963, 981, 992-1014
R/tm_g_distribution.R          1110    1110  0.00%    155-1411
R/tm_g_response.R               364     364  0.00%    161-601
R/tm_g_scatterplot.R            736     736  0.00%    244-1085
R/tm_g_scatterplotmatrix.R      296     277  6.42%    182-516, 577, 591
R/tm_missing_data.R            1111    1111  0.00%    122-1408
R/tm_outliers.R                1031    1031  0.00%    162-1342
R/tm_t_crosstable.R             261     261  0.00%    148-459
R/tm_variable_browser.R         830     825  0.60%    89-1081, 1119-1303
R/utils.R                       156     125  19.87%   81-266, 296-327, 348, 351, 356, 371-392, 403, 408
R/zzz.R                           2       2  0.00%    2-3
TOTAL                          9099    8769  3.63%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 59f00e0

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Dec 11, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
shinytest2-tm_a_pca 💔 $120.07$ $+3.26$ $0$ $0$ $0$ $0$
shinytest2-tm_g_association 💔 $31.60$ $+1.23$ $0$ $0$ $0$ $0$
shinytest2-tm_outliers 💔 $110.41$ $+2.74$ $0$ $0$ $0$ $0$

Results for commit 3071941

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 11, 2024

Unit Tests Summary

  1 files   22 suites   13m 33s ⏱️
150 tests 108 ✅ 42 💤 0 ❌
482 runs  439 ✅ 43 💤 0 ❌

Results for commit 59f00e0.

♻️ This comment has been updated with latest results.

@m7pr m7pr self-assigned this Dec 12, 2024
@llrs-roche llrs-roche merged commit d3fb05b into main Dec 12, 2024
28 of 29 checks passed
@llrs-roche llrs-roche deleted the 813_links_man@main branch December 12, 2024 08:15
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

R CMD CHECK warning and notes

3 participants