Skip to content

Conversation

@gogonzo
Copy link
Contributor

@gogonzo gogonzo commented Feb 3, 2025

transformators arg is addressed in teal. Every module which has data in the server needs a transformators argument

@gogonzo gogonzo added the core label Feb 3, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025

Unit Tests Summary

  1 files   22 suites   12m 59s ⏱️
145 tests 107 ✅ 38 💤 0 ❌
476 runs  438 ✅ 38 💤 0 ❌

Results for commit 9eff874.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025

Unit Tests Summary

  1 files   22 suites   13m 0s ⏱️
145 tests 145 ✅ 0 💤 0 ❌
477 runs  477 ✅ 0 💤 0 ❌

Results for commit 9eff874.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
examples 💔 $0.58$ $+4.21$ $+1$ $-38$ $0$ $0$
shinytest2-tm_a_pca 💚 $118.21$ $-2.05$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
examples 💔 $0.08$ $+1.59$ example_add_facet_labels.Rd

Results for commit 733ddac

♻️ This comment has been updated with latest results.

Copy link
Contributor

@m7pr m7pr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gogonzo Those were omitted during decorators phase, that's why we didn't add any transformators. But I guess transformator has more sense than decorator in here, as we can edit input data with transformators. Decorators do not have much sense in here as there isn't any output that can be really edited.

@gogonzo gogonzo merged commit 91ad352 into main Feb 3, 2025
29 checks passed
@gogonzo gogonzo deleted the add_transformators branch February 3, 2025 12:28
@github-actions github-actions bot locked and limited conversation to collaborators Feb 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants