-
-
Notifications
You must be signed in to change notification settings - Fork 15
Add vignettes on decorators #843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Code Coverage SummaryDiff against mainResults for commit: a9ceb1d Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 22 suites 13m 14s ⏱️ Results for commit a9ceb1d. ♻️ This comment has been updated with latest results. |
Unit Test Performance Difference
Additional test case details
Results for commit c22539b ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I provided some comments and suggestions on the vignette. It is very easy to follow.
One technical note is to split long lines by each sentence instead of in the middle of one. This makes it nicer diff if only one sentences is modified and also shows which sentences are more complex.
# Conflicts: # R/tm_a_pca.R # R/tm_a_regression.R # R/tm_g_association.R # R/tm_g_bivariate.R # R/tm_g_distribution.R # R/tm_g_response.R # R/tm_g_scatterplot.R # R/tm_g_scatterplotmatrix.R # R/tm_missing_data.R # R/tm_outliers.R # R/tm_t_crosstable.R # man/tm_a_pca.Rd # man/tm_a_regression.Rd # man/tm_g_association.Rd # man/tm_g_bivariate.Rd # man/tm_g_distribution.Rd # man/tm_g_response.Rd # man/tm_g_scatterplot.Rd # man/tm_g_scatterplotmatrix.Rd # man/tm_missing_data.Rd # man/tm_outliers.Rd # man/tm_t_crosstable.Rd
7dc69d4 to
a3bed0a
Compare
5f29646 to
a9ceb1d
Compare
Part of insightsengineering/teal#1475
Adds some explanation about decorators functionality of
tmg, since we will remove/reduce confusing decorators vignette inteal. Heavily based onCustomizing Module Outputvignette currently existing inteal, with adjustments to showteal.modules.generalmodules.https://github.com/insightsengineering/teal/blob/c70299587cdf8280c75f7320ae09cd3c67c79837/vignettes/customizing-module-output.Rmd