-
-
Notifications
You must be signed in to change notification settings - Fork 15
Fix missing attached packages #847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This change fixes #786 + adds direct library calls, so that We decided to pay attention to prefixes, to avoid name conflicts. Hovewer we decided not to prefix operators |
This reverts commit 1aba9c5.
|
I think it is ready for review, I'll fix the SuperLinter issues with the review comments. |
Code Coverage SummaryDiff against mainResults for commit: 3037961 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 22 suites 13m 43s ⏱️ Results for commit 3037961. ♻️ This comment has been updated with latest results. |
Unit Test Performance Difference
Additional test case details
Results for commit 934bf2a ♻️ This comment has been updated with latest results. |
|
hey @llrs-roche , really great job with the modules on tmg! I will review each module separately! it might take some time : ) In the meantime, can you have a look at the SuperLinter fail? |
llrs-roche
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressing the remaining comments.
I also found some other calls missing a prefix.
Co-authored-by: Marcin <[email protected]> Signed-off-by: Lluís Revilla <[email protected]>
Pull Request
Fixes #786
This PR load the packages needed before the code is evaluated inside the qenv.
This makes the modules' code more reproducible and solve these errors:
We (@m7pr + me) decided to still add the prefixes on functions to avoid namespace conflicts.