Skip to content

Conversation

@llrs-roche
Copy link
Contributor

Pull Request

Fixes #924

Adds the section title even if no (informative) table can be generated.
If the summary table cannot be generated a placeholder table is generated. This tables doesn't prevent the report to be generated.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 14, 2025

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  -------------------------------------------
R/tm_a_pca.R                    866     866  0.00%    141-1134
R/tm_a_regression.R             752     752  0.00%    180-1028
R/tm_data_table.R               200     200  0.00%    100-348
R/tm_file_viewer.R              172     172  0.00%    47-254
R/tm_front_page.R               143     132  7.69%    77-246
R/tm_g_association.R            321     321  0.00%    161-548
R/tm_g_bivariate.R              675     411  39.11%   332-791, 832, 943, 960, 978, 989-1011
R/tm_g_distribution.R          1107    1107  0.00%    154-1403
R/tm_g_response.R               346     346  0.00%    179-595
R/tm_g_scatterplot.R            710     710  0.00%    261-1066
R/tm_g_scatterplotmatrix.R      273     254  6.96%    200-502, 563, 577
R/tm_missing_data.R            1081    1081  0.00%    124-1381
R/tm_outliers.R                1027    1027  0.00%    162-1339
R/tm_t_crosstable.R             264     264  0.00%    177-483
R/tm_variable_browser.R         788     783  0.63%    89-1025, 1063-1246
R/utils.R                       185     120  35.14%   87-249, 278-304, 316-325, 330, 344-363, 452
R/zzz.R                           2       2  0.00%    2-3
TOTAL                          8912    8548  4.08%

Diff against main

Filename           Stmts    Miss  Cover
---------------  -------  ------  --------
R/tm_outliers.R       +4      +4  +100.00%
TOTAL                 +4      +4  -0.00%

Results for commit: 86d2b32

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

Unit Tests Summary

  1 files  23 suites   1s ⏱️
151 tests 36 ✅ 115 💤 0 ❌
194 runs  79 ✅ 115 💤 0 ❌

Results for commit a49e45a.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 14, 2025

Unit Tests Summary

  1 files  23 suites   2s ⏱️
151 tests 36 ✅ 115 💤 0 ❌
194 runs  79 ✅ 115 💤 0 ❌

Results for commit 86d2b32.

♻️ This comment has been updated with latest results.

@m7pr m7pr self-requested a review October 14, 2025 10:56
@m7pr m7pr self-assigned this Oct 14, 2025
Copy link
Contributor

@m7pr m7pr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming that the issue was fixed.

On main, there is an error when you try to add the module output to the card, but there is no table

image

but on a feature branch it is possible to add a card

image

Copy link
Contributor

@m7pr m7pr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, even though the issue is fixed, I would like to discuss the case if we really need to pollute the code and the card with the empty rtables::rtables. If it's empty, let's don't display anything. A text should be enough.

@m7pr
Copy link
Contributor

m7pr commented Oct 14, 2025

Ok, now the notification is displayed

image

and the code displays the cat

image

I think it might be a bit weird in the Report Previewer that we have a code and a message, but it's crucial for the Show R Code
image

@llrs-roche llrs-roche enabled auto-merge (squash) October 14, 2025 13:58
@llrs-roche llrs-roche merged commit 67755a0 into main Oct 14, 2025
28 of 29 checks passed
@llrs-roche llrs-roche deleted the 924_empty_table@main branch October 14, 2025 14:04
@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: tm_outliers() without categorical variables doesn't generate good code

3 participants