-
-
Notifications
You must be signed in to change notification settings - Fork 15
Warn and create an empty table #930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Code Coverage SummaryDiff against mainResults for commit: 86d2b32 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 23 suites 1s ⏱️ Results for commit a49e45a. |
Unit Tests Summary 1 files 23 suites 2s ⏱️ Results for commit 86d2b32. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, even though the issue is fixed, I would like to discuss the case if we really need to pollute the code and the card with the empty rtables::rtables. If it's empty, let's don't display anything. A text should be enough.
…/teal.modules.general into 924_empty_table@main
…/teal.modules.general into 924_empty_table@main





Pull Request
Fixes #924
Adds the section title even if no (informative) table can be generated.
If the summary table cannot be generated a placeholder table is generated. This tables doesn't prevent the report to be generated.