Skip to content

Fixes plot settings that did not have an accordion wrapper #939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 29, 2025
Merged

Fixes plot settings that did not have an accordion wrapper #939

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fad4a29
fix: plot settings
averissimo Oct 24, 2025
48ba050
chore: fix linter
averissimo Oct 24, 2025
9ee851c
Merge branch 'main' into 937-plot_settings
llrs-roche Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions R/tm_a_pca.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ ui_a_pca <- function(id, ...) {
is_single_dataset = is_single_dataset_value
),
bslib::accordion(
open = TRUE,
open = c("Display", "Pre-processing", "Selected plot specific settings"),
bslib::accordion_panel(
title = "Display",
checkboxGroupInput(
Expand Down Expand Up @@ -321,7 +321,6 @@ ui_a_pca <- function(id, ...) {
),
bslib::accordion_panel(
title = "Plot settings",
collapsed = TRUE,
conditionalPanel(
condition = sprintf(
"input['%s'] == 'Elbow plot' || input['%s'] == 'Eigenvector plot'",
Expand Down
29 changes: 16 additions & 13 deletions R/tm_outliers.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,6 @@ ui_outliers <- function(id, ...) {
open = TRUE,
bslib::accordion_panel(
title = "Method parameters",
collapsed = FALSE,
teal.widgets::optionalSelectInput(
inputId = ns("method"),
label = "Method",
Expand Down Expand Up @@ -362,14 +361,17 @@ ui_outliers <- function(id, ...) {
decorators = select_decorators(args$decorators, "cumulative_plot")
)
),
bslib::accordion_panel(
title = "Plot settings",
selectInput(
inputId = ns("ggtheme"),
label = "Theme (by ggplot):",
choices = ggplot_themes,
selected = args$ggtheme,
multiple = FALSE
bslib::accordion(
open = TRUE,
bslib::accordion_panel(
title = "Plot settings",
selectInput(
inputId = ns("ggtheme"),
label = "Theme (by ggplot):",
choices = ggplot_themes,
selected = args$ggtheme,
multiple = FALSE
)
)
)
),
Expand Down Expand Up @@ -738,10 +740,11 @@ srv_outliers <- function(id, data, outlier_var,
categorical_var_name = as.name(categorical_var)
)
)
) |> within({
table <- rtables::df_to_tt(summary_data)
table
})
) |>
within({
table <- rtables::df_to_tt(summary_data)
table
})
} else {
msg <- "No categorical variable selected, summary table cannot be created."
showNotification(msg,
Expand Down
3 changes: 1 addition & 2 deletions R/tm_variable_browser.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,10 +160,9 @@ ui_variable_browser <- function(id,
teal.widgets::plot_with_settings_ui(ns("variable_plot")),
tags$br(),
bslib::accordion(
open = TRUE,
open = FALSE,
bslib::accordion_panel(
title = "Plot settings",
collapsed = TRUE,
selectInput(
inputId = ns("ggplot_theme"), label = "ggplot2 theme",
choices = ggplot_themes,
Expand Down
Loading