-
-
Notifications
You must be signed in to change notification settings - Fork 15
picks #942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gogonzo
wants to merge
174
commits into
main
Choose a base branch
from
redesign_extraction@main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+6,834
−1,286
Open
picks #942
Changes from all commits
Commits
Show all changes
174 commits
Select commit
Hold shift + click to select a range
12f095c
WIP
gogonzo d348719
brush_filter to the module
gogonzo 947f151
encapsulate brushing functionality
gogonzo 842ba1b
fix add filter state
gogonzo a9c9b06
scatterplot + data_table
gogonzo bf7b4c4
Merge branch 'main' into spotfire_poc2
gogonzo 4b987a6
WIP
gogonzo 089a06a
add data_table module to the app
gogonzo e0969da
[skip roxygen] [skip vbump] Roxygen Man Pages Auto Update
dependabot-preview[bot] c5c744d
remove unneeded
gogonzo 67d4a5c
wip
gogonzo 70d0772
quick fix
gogonzo 2e49a7a
generalise to enable faceting
gogonzo 4038ba8
dummy adam example
gogonzo 06bf0a4
feat: add example using the poc data
vedhav b9e03c2
WIP plotly
gogonzo 32ee42f
plotly_specs as simple list
gogonzo 4321350
data_table as a brushing table
gogonzo 4137aa1
hide table when not brushed
gogonzo f1b5d51
feat: allow the user to pass custom colors and symbols
vedhav 780924c
feat: reproduce the osprey example
vedhav ea559d3
fix: filter using teal.slice and not during data creation
vedhav 21eff43
rename srv_page_data_table to srv_data_table
gogonzo ea67bd0
feat: add refrence lines + filter unwanted data
vedhav f913acb
display brushed only
gogonzo 7d5bc89
push local changes
vedhav 179f145
export the custom module for deployment
vedhav e18dfc3
pass plotly_selected only when it is supported
vedhav b5884a2
feat: use reactable
vedhav ef85449
fix: avoid ns clash of layout
vedhav ef8a5ab
chore: remove local change
vedhav 0fff2a7
feat: use main version of teal and update spiderplot module
vedhav b8a60c3
feat: update the spiderplot tables + UI enhancements + single parent
vedhav 17e74e3
fix: format the links in two tables
vedhav d2636fb
feat: add a two module POC for easy maintenance
vedhav b63249a
Merge branch 'main' into poc3@spotfire_poc2
gogonzo 915ffdf
WIP modules
gogonzo d028c8e
labels to the data
gogonzo 78e1f2a
fix
gogonzo 2c94370
add reactable module
gogonzo 4f62e13
wip modularize
gogonzo 2065b71
autolabels
gogonzo 7b5ed64
further abstraction
gogonzo 7426193
fixes
gogonzo c398ee8
swimlane module wip
gogonzo e68d78f
further changes .adjust_colors
gogonzo 0cd5adc
recent
gogonzo 1596f2d
update the app code
vedhav bb0917c
WIP waterfall
gogonzo ef300f5
update
gogonzo 3536699
namespace fix
gogonzo 3eb068a
swimlane with tabs
gogonzo cfbabc2
poc_onco_v1
gogonzo bea4996
WIP
gogonzo 2f598c8
Merge branch 'main' into poc3@spotfire_poc2
gogonzo b496a7e
swimlane fix shapes and fct order
gogonzo 7590be1
wip
gogonzo cabb695
fix reactables reactivity
gogonzo 29517c8
sort input swimlane
gogonzo 246bfb2
v3
gogonzo 9d51de3
v4
gogonzo b1e4f60
wip
gogonzo 9c37a22
freeze column
gogonzo cf14bcf
wip v5
gogonzo bf0cbad
wip v5
gogonzo e9ac824
wip v5
gogonzo 165d891
wip v5
gogonzo 607105a
spiderplot lines blue
gogonzo cb5c616
wip v5
gogonzo 18fd08c
wip v5
gogonzo 02040a5
wip v5
gogonzo b926f35
wip v5
gogonzo 4495bc7
major cleaning
gogonzo ae795f8
minor fix
gogonzo c6e44f5
major cleaning
gogonzo 08465f6
add graphs to the namespace
gogonzo b6ed653
tm_rmarkdown
gogonzo a128ff7
tm_rmarkdown
gogonzo bc1b4ad
tm_rmarkdown
gogonzo 2bbbb96
choices selected
gogonzo 8234f77
update
gogonzo 7a26589
chore: format package
vedhav 0c2e874
fix: handle color and shape edge cases + rename `event_var` param in …
vedhav a065bf5
docs: add examples
vedhav 589afce
feat: allow the app developer to customize tooltips using column names
vedhav 4dd1b59
feat: allow custome siize based on a column + expand cards
vedhav ce441c3
docs: update roxygen docs for new params
vedhav a840f29
feat: add the show selected tooltips module
vedhav 68d212f
feat: improve the trigger tooltips
vedhav 8a364bd
fix: remove unused param
vedhav 4d41676
feat: simplify the trigger tooltip logic
vedhav 00b5cf8
[skip style] [skip vbump] Restyle files
github-actions[bot] 723c084
[skip roxygen] [skip vbump] Roxygen Man Pages Auto Update
github-actions[bot] 4126c6b
feat: implement the subject selection for spiider plot
vedhav 25f7aac
feat: modify the point_size to work like point_colors and point_symbols
vedhav 1a7951f
Merge branch 'main' into poc3@spotfire_poc2
vedhav 1a82823
chore: fix errors in module
vedhav 0092add
feat: decouple the plot functions and rename module functions
vedhav 93bc7d9
fix: update docs and namespace
vedhav 392c394
chore: rename internal functions too
vedhav c338ea0
feat: add the new scatterplot module
vedhav 95310d3
chore: add pkg namespace
vedhav de3b770
fix: stop using internal functions inside the qenv
vedhav f4a13ef
feat: add MVP version of line and barplot
vedhav 9ad1397
fix: add pkg namespace
vedhav 1a42f2a
fix: move filter out of args into transformators
vedhav d2b2ff0
feat: add lines to the scatterplot
vedhav 0613aea
fix: fix error when `sort_var` is not specified in `tm_p_swimlane`
vedhav 620f74f
chore: remove subject selection tooltip
vedhav 7acd618
chore: remove print
vedhav 2cc3595
docs: add func docs
vedhav 624bbd7
fix: remove unwanted data grouping
vedhav 4889032
fix: ungroup before plot
vedhav 0be199b
fix: retain the labels for grouped vars and color var
vedhav 1e5be80
feat: add a poc of a module that uses multiple modules
vedhav 8e338ac
feat: hide widgets using module arg
vedhav e144900
feat: hide widgets using module arg
vedhav eb0f489
feat: hide widgets from the module
vedhav d660198
fix: add pkg prefix for code reproducibility
vedhav f9f5bf9
only join when there's a record
6bcd1f5
feat: move table outside swimlane
vedhav 66e980e
feat: apply filter logic for the table
vedhav 00eff7d
Merge remote-tracking branch 'origin/main' into submodules@poc3@spotf…
vedhav cb5e725
spiderplot with `picks`
gogonzo 8c251ed
feat: add spaghetti plot module + improve scatter and line plot modules
vedhav 882823f
Merge branch 'submodules@poc3@spotfire_poc2' into redesign_extraction…
vedhav 848e89b
fix: use package prefix `layout` is exported in graphics, igraph, and…
vedhav 636a0cd
fix: use package prefix `layout` is exported in graphics, igraph, and…
vedhav f14992e
typo
vedhav 6d42589
Merge branch 'submodules@poc3@spotfire_poc2' into redesign_extraction…
vedhav 210cb1b
chore: remove local log
vedhav 027b58b
Merge branch 'submodules@poc3@spotfire_poc2' into redesign_extraction…
vedhav fe7be25
chore: remove legacy subject tooltip triggers
vedhav 86a58d1
Merge branch 'submodules@poc3@spotfire_poc2' into redesign_extraction…
vedhav d647ee1
feat: improve bargraph and add double_bargraph module
vedhav 6d4a216
Merge branch 'submodules@poc3@spotfire_poc2' into redesign_extraction…
vedhav 4b0a1a7
docs: rename double bargraph to drilldown bargraph + add docs
vedhav 565b100
Merge branch 'submodules@poc3@spotfire_poc2' into redesign_extraction…
vedhav a78a083
fix: update examples with `tooltip_vars` usage and fix errors related…
vedhav eb11ff6
Merge branch 'submodules@poc3@spotfire_poc2' into redesign_extraction…
vedhav b5d04e2
feat: add the ability to customize tooltips in bargraph
vedhav f041216
Merge branch 'submodules@poc3@spotfire_poc2' into redesign_extraction…
vedhav e07755f
update
gogonzo d04c116
feat: move the mdr modules outside tmg + split waterfall module
vedhav 40aedde
Merge branch 'submodules@poc3@spotfire_poc2' into redesign_extraction…
vedhav 0edbeb6
fix scatter and lineplot
gogonzo 0a88128
picks to spaghetti
gogonzo b8eb22a
fixes
gogonzo 3e3acb7
fix some modules
gogonzo 61b2cfd
minor
gogonzo a353348
Merge remote-tracking branch 'origin/main' into redesign_extraction@main
gogonzo 8764312
link remotes
gogonzo 52a492b
validate_input
gogonzo ccf0d8d
fix validation when >1 x vars selected and plot Response vs Regressor
gogonzo 6ec2fb7
update
gogonzo 2049b98
tm_distribution ready
gogonzo eb65be4
tmg is using picks
gogonzo c3e8381
rename files so that .default is still in the original file
gogonzo ea0bae0
roxy
gogonzo 460cb36
Merge branch 'main' into redesign_extraction@main
gogonzo a71bb7f
remove src
gogonzo 43c914a
Merge branch 'main' into redesign_extraction@main
gogonzo 7ec893d
update docs
gogonzo c91a8ee
rename mathods in teal.transform
gogonzo fbab319
spec -> picks
gogonzo d05d134
Merge branch 'main' into redesign_extraction@main
gogonzo 53da6a5
wip
gogonzo 00c7e24
Merge remote-tracking branch 'origin/main' into redesign_extraction@main
gogonzo f8b884f
[skip style] [skip vbump] Restyle files
github-actions[bot] f7b6c2c
cleanup
gogonzo 5cf93d7
remove values() after variables(multiple = TRUE)
gogonzo 2556fae
remove values() after variables(multiple = TRUE)
gogonzo b092e25
revert unnecessary differences with main
gogonzo 8cbcebf
[skip roxygen] [skip vbump] Roxygen Man Pages Auto Update
github-actions[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -48,6 +48,7 @@ Imports: | |||||||
| lattice (>= 0.18-4), | ||||||||
| lifecycle (>= 0.2.0), | ||||||||
| MASS (>= 7.3-60), | ||||||||
| rlang, | ||||||||
| rtables (>= 0.6.11), | ||||||||
| scales (>= 1.3.0), | ||||||||
| shinyjs (>= 2.1.0), | ||||||||
|
|
@@ -72,8 +73,6 @@ Suggests: | |||||||
| logger (>= 0.4.0), | ||||||||
| nestcolor (>= 0.1.0), | ||||||||
| pkgload, | ||||||||
| rlang (>= 1.0.0), | ||||||||
| rmarkdown (>= 2.23), | ||||||||
| roxy.shinylive, | ||||||||
| rvest, | ||||||||
| shinytest2, | ||||||||
|
|
@@ -83,8 +82,8 @@ VignetteBuilder: | |||||||
| knitr, | ||||||||
| rmarkdown | ||||||||
| Remotes: | ||||||||
| insightsengineering/teal, | ||||||||
| insightsengineering/teal.reporter | ||||||||
| insightsengineering/teal@redesign_extraction@main, | ||||||||
| insightsengineering/teal.transform@redesign_extraction@main | ||||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. IMHO
Suggested change
|
||||||||
| Config/Needs/verdepcheck: haleyjeppson/ggmosaic, tidyverse/ggplot2, | ||||||||
| rstudio/shiny, insightsengineering/teal, | ||||||||
| insightsengineering/teal.transform, mllg/checkmate, tidyverse/dplyr, | ||||||||
|
|
||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| .picks_datanames <- function(x) { | ||
| checkmate::assert_list(x, c("picks", "NULL")) | ||
| datanames_list <- lapply(x, function(x) { | ||
| if (is.character(x$datasets$choices)) { | ||
| x$datasets$choices | ||
| } else { | ||
| NULL | ||
| } | ||
| }) | ||
|
|
||
| if (any(vapply(datanames_list, is.null, logical(1)))) { | ||
| "all" | ||
| } else { | ||
| unique(unlist(datanames_list)) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.