Skip to content

Conversation

@donyunardi
Copy link
Contributor

Fixes #928

@donyunardi donyunardi added the core label Dec 3, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025

Unit Tests Summary

  1 files   24 suites   15m 50s ⏱️
167 tests 162 ✅ 5 💤 0 ❌
483 runs  478 ✅ 5 💤 0 ❌

Results for commit 934c296.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
examples 💚 $5.39$ $-4.70$ $0$ $+42$ $0$ $0$
shinytest2-tm_a_pca 💚 $146.74$ $-145.65$ $-38$ $+11$ $0$ $0$
shinytest2-tm_a_regression 💚 $69.86$ $-69.21$ $-24$ $+7$ $0$ $0$
shinytest2-tm_data_table 💚 $28.58$ $-28.19$ $-6$ $+4$ $0$ $0$
shinytest2-tm_file_viewer 💚 $34.23$ $-33.38$ $-9$ $+4$ $0$ $0$
shinytest2-tm_front_page 💚 $26.15$ $-25.60$ $-6$ $+3$ $0$ $0$
shinytest2-tm_g_bivariate 💚 $92.14$ $-91.74$ $-40$ $+4$ $0$ $0$
shinytest2-tm_g_distribution 💚 $59.38$ $-59.13$ $-17$ $+3$ $0$ $0$
shinytest2-tm_g_response 💚 $38.05$ $-37.70$ $-13$ $+4$ $0$ $0$
shinytest2-tm_g_scatterplot 💚 $76.19$ $-75.71$ $-30$ $+5$ $0$ $0$
shinytest2-tm_g_scatterplotmatrix 💚 $34.68$ $-34.09$ $-5$ $+4$ $0$ $0$
shinytest2-tm_missing_data 💚 $59.39$ $-58.58$ $-17$ $+4$ $0$ $0$
shinytest2-tm_outliers 💚 $149.68$ $-148.66$ $-51$ $+10$ $0$ $0$
shinytest2-tm_t_crosstable 💚 $39.38$ $-38.61$ $-5$ $+4$ $0$ $0$
shinytest2-tm_variable_browser 💚 $88.39$ $-87.74$ $-17$ $+6$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
examples 💚 $2.03$ $-2.02$ example_add_facet_labels.Rd
shinytest2-tm_a_pca 💚 $13.56$ $-13.48$ e2e_tm_a_pca_Changing_output_encodings_for_plot_type_does_not_generate_errors.
shinytest2-tm_a_pca 💚 $7.76$ $-7.68$ e2e_tm_a_pca_Changing_output_encodings_of_NA_action_does_not_generate_errors.
shinytest2-tm_a_pca 💚 $21.06$ $-20.98$ e2e_tm_a_pca_Changing_output_encodings_of_font_size_does_not_generate_errors.
shinytest2-tm_a_pca 💚 $31.92$ $-31.84$ e2e_tm_a_pca_Changing_output_encodings_of_plot_type_hides_and_shows_options.
shinytest2-tm_a_pca 💚 $13.22$ $-13.14$ e2e_tm_a_pca_Changing_output_encodings_of_standardization_does_not_generate_errors.
shinytest2-tm_a_pca 💚 $8.57$ $-8.48$ e2e_tm_a_pca_Changing_output_encodings_of_tables_display_does_not_generate_errors.
shinytest2-tm_a_pca 💚 $9.34$ $-9.25$ e2e_tm_a_pca_Changing_output_encodings_of_theme_does_not_generate_errors.
shinytest2-tm_a_pca 💚 $12.03$ $-11.94$ e2e_tm_a_pca_Color_by_columns_data_extract_must_be_from_non_selected_variable_set.
shinytest2-tm_a_pca 💚 $8.40$ $-8.30$ e2e_tm_a_pca_Eigenvector_table_should_have_data_extract_selection_Murder_Assault_on_header.
shinytest2-tm_a_pca 💚 $11.84$ $-11.75$ e2e_tm_a_pca_Eigenvector_table_should_have_data_extract_selection_Murder_UrbanPop_on_header.
shinytest2-tm_a_pca 💚 $9.04$ $-8.82$ e2e_tm_a_pca_Module_is_initialised_with_the_specified_defaults_in_function_call.
shinytest2-tm_a_regression 💚 $6.77$ $-6.66$ e2e_tm_a_regression_Data_extract_spec_elements_are_initialized_with_the_default_values_specified_by_response_and_regressor_arg.
shinytest2-tm_a_regression 💚 $6.73$ $-6.62$ e2e_tm_a_regression_Data_parameter_and_module_label_is_passed_properly.
shinytest2-tm_a_regression 💚 $11.10$ $-11.02$ e2e_tm_a_regression_Outlier_definition_and_label_are_visible_by_default.
shinytest2-tm_a_regression 💚 $6.83$ $-6.74$ e2e_tm_a_regression_Outlier_definition_and_label_have_default_values_and_label_text.
shinytest2-tm_a_regression 💚 $17.24$ $-17.15$ e2e_tm_a_regression_Plot_type_has_7_specific_choices_changing_choices_does_not_throw_errors.
shinytest2-tm_a_regression 💚 $8.84$ $-8.75$ e2e_tm_a_regression_Plot_type_is_set_properly.
shinytest2-tm_a_regression 💚 $12.36$ $-12.27$ e2e_tm_a_regression_Unchecking_display_outlier_hides_outlier_label_and_definition.
shinytest2-tm_data_table 💚 $6.19$ $-6.08$ e2e_tm_data_table_Initializes_without_errors
shinytest2-tm_data_table 💚 $6.15$ $-6.06$ e2e_tm_data_table_Verify_checkbox_displayed_over_data_table
shinytest2-tm_data_table 💚 $7.02$ $-6.93$ e2e_tm_data_table_Verify_default_variable_selection_and_set_new_selection
shinytest2-tm_data_table 💚 $9.22$ $-9.12$ e2e_tm_data_table_Verify_module_displays_data_table
shinytest2-tm_file_viewer 💚 $6.84$ $-6.38$ e2e_tm_file_viewer_Initializes_without_errors_and_shows_files_tree_specified_in_input_path_argument
shinytest2-tm_file_viewer 💚 $9.15$ $-9.02$ e2e_tm_file_viewer_Shows_selected_image_file
shinytest2-tm_file_viewer 💚 $8.97$ $-8.84$ e2e_tm_file_viewer_Shows_selected_text_file
shinytest2-tm_file_viewer 💚 $9.27$ $-9.14$ e2e_tm_file_viewer_Shows_selected_url
shinytest2-tm_front_page 💚 $5.67$ $-5.52$ e2e_tm_front_page_Initializes_without_errors_and_check_html_elements
shinytest2-tm_front_page 💚 $10.59$ $-10.34$ e2e_tm_front_page_Verify_the_module_displays_metadata
shinytest2-tm_front_page 💚 $9.89$ $-9.74$ e2e_tm_front_page_Verify_the_module_displays_tables
shinytest2-tm_g_bivariate 💚 $21.67$ $-21.57$ e2e_tm_g_bivariate_Coloring_options_are_hidden_when_coloring_is_toggled_off.
shinytest2-tm_g_bivariate 💚 $26.07$ $-25.98$ e2e_tm_g_bivariate_Facetting_options_are_hidden_when_facet_is_toggled_off.
shinytest2-tm_g_bivariate 💚 $8.00$ $-7.89$ e2e_tm_g_bivariate_Module_is_initialised_with_the_specified_defaults.
shinytest2-tm_g_bivariate 💚 $36.40$ $-36.30$ e2e_tm_g_bivariate_Setting_encoding_inputs_produces_outputs_without_validation_errors.
shinytest2-tm_g_distribution 💚 $21.60$ $-21.51$ e2e_tm_g_distribution_Histogram_encoding_inputs_produce_output_without_validation_errors.
shinytest2-tm_g_distribution 💚 $24.96$ $-24.88$ e2e_tm_g_distribution_Module_is_initialised_with_the_specified_defaults.
shinytest2-tm_g_distribution 💚 $12.83$ $-12.74$ e2e_tm_g_distribution_QQ_plot_encoding_inputs_produce_output_without_validation_errors.
shinytest2-tm_g_response 💚 $7.35$ $-7.26$ e2e_tm_g_response_deselecting_response_produces_validation_error.
shinytest2-tm_g_response 💚 $7.34$ $-7.26$ e2e_tm_g_response_deselecting_x_produces_validation_error.
shinytest2-tm_g_response 💚 $16.32$ $-16.23$ e2e_tm_g_response_encoding_inputs_produce_output_without_validation_errors.
shinytest2-tm_g_response 💚 $7.03$ $-6.95$ e2e_tm_g_response_module_is_initialised_with_the_specified_defaults.
shinytest2-tm_g_scatterplot 💚 $11.06$ $-10.95$ e2e_tm_g_scatterplot_Base_for_the_log_transformation_can_be_applied.
shinytest2-tm_g_scatterplot 💚 $9.13$ $-9.04$ e2e_tm_g_scatterplot_Get_validation_error_when_facetting_with_the_same_row_col_variable.
shinytest2-tm_g_scatterplot 💚 $7.45$ $-7.36$ e2e_tm_g_scatterplot_Module_is_initialised_with_the_specified_defaults.
shinytest2-tm_g_scatterplot 💚 $37.06$ $-36.97$ e2e_tm_g_scatterplot_The_encoding_inputs_are_set_without_validation_errors.
shinytest2-tm_g_scatterplot 💚 $11.48$ $-11.40$ e2e_tm_g_scatterplot_The_log_transform_is_only_possible_for_positive_numeric_vars.
shinytest2-tm_g_scatterplotmatrix 💚 $10.77$ $-10.63$ e2e_tm_g_scatterplotmatrix_Change_plot_settings
shinytest2-tm_g_scatterplotmatrix 💚 $6.74$ $-6.59$ e2e_tm_g_scatterplotmatrix_Initializes_without_errors
shinytest2-tm_g_scatterplotmatrix 💚 $8.26$ $-8.13$ e2e_tm_g_scatterplotmatrix_Verify_default_values_and_settings_data_extracts_for_data_selection
shinytest2-tm_g_scatterplotmatrix 💚 $8.90$ $-8.75$ e2e_tm_g_scatterplotmatrix_Verify_module_displays_data_table
shinytest2-tm_missing_data 💚 $17.45$ $-17.25$ e2e_tm_missing_data_Check_default_settings_and_visibility_of_the_combinations_graph_and_encodings
shinytest2-tm_missing_data 💚 $17.24$ $-17.03$ e2e_tm_missing_data_Default_settings_and_visibility_of_the_summary_graph
shinytest2-tm_missing_data 💚 $7.91$ $-7.70$ e2e_tm_missing_data_Initializes_without_errors
shinytest2-tm_missing_data 💚 $16.79$ $-16.59$ e2e_tm_missing_data_Validate_functionality_and_UI_response_for_By_Variable_Levels_
shinytest2-tm_outliers 💚 $13.91$ $-13.80$ e2e_tm_outliers_Data_extract_spec_elements_are_initialized_with_the_default_values_specified_by_outlier_var_and_categorical_var_argument.
shinytest2-tm_outliers 💚 $9.30$ $-9.19$ e2e_tm_outliers_Data_parameter_and_module_label_is_passed_properly.
shinytest2-tm_outliers 💚 $13.94$ $-13.84$ e2e_tm_outliers_Default_radio_buttons_are_set_properly.
shinytest2-tm_outliers 💚 $9.33$ $-9.23$ e2e_tm_outliers_Method_parameters_are_set_properly.
shinytest2-tm_outliers 💚 $9.24$ $-9.13$ e2e_tm_outliers_Module_is_divided_into_3_tabs.
shinytest2-tm_outliers 💚 $31.57$ $-31.47$ e2e_tm_outliers_Outlier_definition_text_and_range_are_displayed_properly_depending_on_method.
shinytest2-tm_outliers 💚 $14.06$ $-13.96$ e2e_tm_outliers_Outlier_table_is_displayed_with_proper_content.
shinytest2-tm_outliers 💚 $15.87$ $-15.77$ e2e_tm_outliers_Outliers_summary_table_is_displayed_with_proper_content.
shinytest2-tm_outliers 💚 $11.72$ $-11.62$ e2e_tm_outliers_Plot_type_is_correctly_set_by_default_and_has_appropriate_possible_options.
shinytest2-tm_outliers 💚 $20.75$ $-20.65$ e2e_tm_outliers_Plot_type_is_hidden_when_Boxplot_tab_is_not_selected.
shinytest2-tm_t_crosstable 💚 $12.57$ $-12.46$ e2e_tm_t_crosstable_Change_plot_settings
shinytest2-tm_t_crosstable 💚 $7.40$ $-7.03$ e2e_tm_t_crosstable_Initializes_without_errors
shinytest2-tm_t_crosstable 💚 $9.85$ $-9.72$ e2e_tm_t_crosstable_Verify_default_values_and_settings_data_extracts_for_data_selection
shinytest2-tm_t_crosstable 💚 $9.56$ $-9.40$ e2e_tm_t_crosstable_Verify_module_displays_data_table
shinytest2-tm_variable_browser 💚 $13.16$ $-13.05$ e2e_tm_variable_browser_Selecting_treat_variable_as_factor_changes_the_table_headers.
shinytest2-tm_variable_browser 💚 $14.71$ $-14.60$ e2e_tm_variable_browser_changing_display_density_encoding_doesn_t_show_errors.
shinytest2-tm_variable_browser 💚 $18.06$ $-17.96$ e2e_tm_variable_browser_changing_outlier_definition_encoding_doesn_t_show_errors.
shinytest2-tm_variable_browser 💚 $20.76$ $-20.65$ e2e_tm_variable_browser_changing_plot_setting_encodings_doesn_t_show_errors.
shinytest2-tm_variable_browser 💚 $10.87$ $-10.75$ e2e_tm_variable_browser_content_is_displayed_correctly.
shinytest2-tm_variable_browser 💚 $10.83$ $-10.73$ e2e_tm_variable_browser_selection_of_categorical_variable_has_a_table_with_level_header.

Results for commit d693bc2

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  -------------------------------------------
R/geom_mosaic.R                  73      73  0.00%    37-225
R/tm_a_pca.R                    864     864  0.00%    141-1132
R/tm_a_regression.R             751     751  0.00%    180-1027
R/tm_data_table.R               200     200  0.00%    100-348
R/tm_file_viewer.R              172     172  0.00%    50-257
R/tm_front_page.R               143     132  7.69%    77-246
R/tm_g_association.R            320     320  0.00%    161-547
R/tm_g_bivariate.R              672     408  39.29%   332-788, 829, 940, 957, 975, 986-1008
R/tm_g_distribution.R          1106    1106  0.00%    156-1404
R/tm_g_response.R               345     345  0.00%    179-594
R/tm_g_scatterplot.R            709     709  0.00%    261-1065
R/tm_g_scatterplotmatrix.R      272     253  6.99%    200-501, 562, 576
R/tm_missing_data.R            1172    1172  0.00%    126-1475
R/tm_outliers.R                1029    1029  0.00%    162-1341
R/tm_rmarkdown.R                154      68  55.84%   144-196, 225-240, 284-285, 345-368
R/tm_t_crosstable.R             263     263  0.00%    177-482
R/tm_variable_browser.R         887     881  0.68%    89-1113, 1164-1347
R/utils.R                       185     120  35.14%   87-250, 279-305, 317-326, 331, 345-364, 453
R/zzz.R                           2       2  0.00%    2-3
TOTAL                          9319    8868  4.84%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 934c296

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@donyunardi
Copy link
Contributor Author

submitted to CRAN. Awaiting feedback.

Copy link

@osenan osenan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad that all tests are fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CRAN Release]: 0.6.0

3 participants