rewrite scatterplotmatrix so it uses patchwork

DESCRIPTION

@@ -46,8 +46,8 @@ Imports:
     gridExtra (>= 2.3),
     htmlwidgets (>= 1.6.4),
     jsonlite (>= 1.8.9),
-    lattice (>= 0.18-4),
     lifecycle (>= 0.2.0),
+    patchwork (>= 1.2.0),
     MASS (>= 7.3-60),
     rmarkdown (>= 2.23),
     rtables (>= 0.6.11),
@@ -100,7 +100,7 @@ Config/Needs/verdepcheck: haleyjeppson/ggmosaic, tidyverse/ggplot2,
     tidyverse/tibble, tidyverse/tidyr, daattali/colourpicker,
     daattali/ggExtra, aphalo/ggpmisc, aphalo/ggpp, slowkow/ggrepel,
     baddstats/goftest, ramnathv/htmlwidgets, jeroen/jsonlite, yihui/knitr,
-    daroczig/logger, deepayan/lattice, insightsengineering/nestcolor,
+    daroczig/logger, thomasp85/patchwork, insightsengineering/nestcolor,
     r-lib/pkgload, r-lib/rlang, rstudio/rmarkdown,
     insightsengineering/roxy.shinylive, insightsengineering/rtables,
     tidyverse/rvest, htmlwidgets/sparkline, rstudio/shinytest2,

NAMESPACE

@@ -12,7 +12,6 @@ S3method(teal.reporter::to_rmd,markdown_internal)
 S3method(tools::toHTML,markdown_internal)
 export(add_facet_labels)
 export(geom_mosaic)
-export(get_scatterplotmatrix_stats)
 export(tm_a_pca)
 export(tm_a_regression)
 export(tm_data_table)

NEWS.md

@@ -5,8 +5,12 @@
 - Modules now return a `teal_report` object that contains the data, code and reporter. All the reporter buttons were removed from the modules' UI.
 - Support case when both variables are categorical in association and bivariate plots.
 - Improve `tm_missing_data` visualization (#495).
-- Multiple decorators can be applied to the same output object (#978).
-- Introduced `tm_gtsummary()`, a new module for generating tables using the [gtsummary](https://cran.r-project.org/package=gtsummary) package (#973).
+- `tm_g_scatterplotmatrix()` has been rewritten to use `ggplot2` and `patchwork`
+  instead of `lattice`. Panel text scales automatically with the number of
+  variables so labels remain readable at any matrix size. NA handling retains
+  the familiar **Omit NAs** checkbox (default, `use = "pairwise.complete.obs"`);
+  unchecking it reveals a dropdown with all five `stats::cor()` `use` options.
+  `get_scatterplotmatrix_stats()` has been removed (#986).
 
 # teal.modules.general 0.5.1
 

R/tm_a_regression.R

@@ -230,7 +230,6 @@ tm_a_regression <- function(label = "Regression Analysis",
   checkmate::assert_multi_class(post_output, c("shiny.tag", "shiny.tag.list", "html"), null.ok = TRUE)
   checkmate::assert_choice(default_plot_type, seq.int(1L, length(plot_choices)))
   checkmate::assert_string(default_outlier_label)
-  assert_decorators(decorators)
 
   if (length(label_segment_threshold) == 1) {
     checkmate::assert_numeric(label_segment_threshold, any.missing = FALSE, finite = TRUE)