Skip to content

restructure sections#321

Merged
m7pr merged 2 commits intomainfrom
400_include_filter_state_yaml
Oct 17, 2025
Merged

restructure sections#321
m7pr merged 2 commits intomainfrom
400_include_filter_state_yaml

Conversation

@m7pr
Copy link
Contributor

@m7pr m7pr commented Oct 14, 2025

@m7pr m7pr added the core label Oct 14, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 14, 2025

Unit Tests Summary

 1 files   1 suites   0s ⏱️
 4 tests  4 ✅ 0 💤 0 ❌
13 runs  13 ✅ 0 💤 0 ❌

Results for commit a93b67b.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 14, 2025

badge

Code Coverage Summary

Filename                    Stmts    Miss  Cover    Missing
------------------------  -------  ------  -------  --------------
R/tm_g_ae_oview.R             225     225  0.00%    84-337
R/tm_g_ae_sub.R               288     288  0.00%    60-379
R/tm_g_butterfly.R            371     371  0.00%    125-534
R/tm_g_decorate.R              42      42  0.00%    17-91
R/tm_g_events_term_id.R       271     271  0.00%    63-364
R/tm_g_heat_bygrade.R         293     293  0.00%    136-459
R/tm_g_patient_profile.R      691     691  0.00%    159-913
R/tm_g_spiderplot.R           322     322  0.00%    100-464
R/tm_g_swimlane.R             345     345  0.00%    127-525
R/tm_g_waterfall.R            429     429  0.00%    109-590
R/utils.R                      85      80  5.88%    31-73, 107-240
R/zzz.R                         3       3  0.00%    4-7
TOTAL                        3365    3360  0.15%

Diff against main

Filename                    Stmts    Miss  Cover
------------------------  -------  ------  --------
R/tm_g_ae_oview.R              -1      -1  +100.00%
R/tm_g_ae_sub.R                -1      -1  +100.00%
R/tm_g_butterfly.R             -1      -1  +100.00%
R/tm_g_events_term_id.R        -1      -1  +100.00%
R/tm_g_heat_bygrade.R          -1      -1  +100.00%
R/tm_g_patient_profile.R       -1      -1  +100.00%
R/tm_g_spiderplot.R            -1      -1  +100.00%
R/tm_g_swimlane.R              -1      -1  +100.00%
R/tm_g_waterfall.R             -1      -1  +100.00%
TOTAL                          -9      -9  +0.00%

Results for commit: a93b67b

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

@llrs-roche llrs-roche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Table of contents look ok:

Image

I couldn't find any other section titles to modify.


However, I noticed that it doesn't have any code to load the data for the app. The report starts with the module without any code showing how the data is loaded.

@llrs-roche llrs-roche self-assigned this Oct 15, 2025
@m7pr
Copy link
Contributor Author

m7pr commented Oct 15, 2025

@llrs-roche what do you mean in here

However, I noticed that it doesn't have any code to load the data for the app. The report starts with the module without any code showing how the data is loaded.

Each module has Data preparation sesction. It's even visible on your print screen

image

@llrs-roche
Copy link
Contributor

If you run the first 4 lines of code (without the pipe) on a fresh R session you'll see that it generates an error. It lacks loading a library with the rADRS being loaded. rADRS is present on osprey but the library is not loaded or available, so the code is not reproducible.

@m7pr
Copy link
Contributor Author

m7pr commented Oct 15, 2025

@llrs-roche it's not the reason of the package, but the reason of how you prepared teal_data.
If you used the code from this Discussion
#318

then you can see it's the reason of data preparations : )

But honestly we assume you will run library(teal.osprey), this actually attaches teal since teal is in Depends, and when teal is attached then teal.data is also attached, as teal.data is in the Depends of teal.

So the only missing part is running library(teal.osprey) but that's a silent assumption that you execute it : P
It also happens in the examples in this package.

image

@m7pr m7pr merged commit 8b92e84 into main Oct 17, 2025
26 checks passed
@m7pr m7pr deleted the 400_include_filter_state_yaml branch October 17, 2025 11:04
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants