Skip to content

update datanames in wf#306

Merged
kumamiao merged 2 commits intomainfrom
304_wf_datanames
Jul 1, 2025
Merged

update datanames in wf#306
kumamiao merged 2 commits intomainfrom
304_wf_datanames

Conversation

@kumamiao
Copy link
Contributor

Fixes #304

@github-actions
Copy link
Contributor

github-actions bot commented Jun 30, 2025

✅ All contributors have signed the CLA
Posted by the CLA Assistant Lite bot.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 30, 2025

badge

Code Coverage Summary

Filename                    Stmts    Miss  Cover    Missing
------------------------  -------  ------  -------  --------------
R/tm_g_ae_oview.R             247     247  0.00%    83-362
R/tm_g_ae_sub.R               310     310  0.00%    60-405
R/tm_g_butterfly.R            383     383  0.00%    124-546
R/tm_g_decorate.R              47      47  0.00%    18-99
R/tm_g_events_term_id.R       294     294  0.00%    63-394
R/tm_g_heat_bygrade.R         315     315  0.00%    135-485
R/tm_g_patient_profile.R      712     712  0.00%    157-936
R/tm_g_spiderplot.R           337     337  0.00%    99-482
R/tm_g_swimlane.R             368     368  0.00%    126-550
R/tm_g_waterfall.R            441     441  0.00%    108-604
R/utils.R                      50      45  10.00%   32-91, 125-155
R/zzz.R                         3       3  0.00%    4-7
TOTAL                        3507    3502  0.14%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: ac4fea1

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Jun 30, 2025

Unit Tests Summary

 1 files   1 suites   0s ⏱️
 4 tests  4 ✅ 0 💤 0 ❌
13 runs  13 ✅ 0 💤 0 ❌

Results for commit ac4fea1.

♻️ This comment has been updated with latest results.

@kumamiao
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@kumamiao kumamiao requested a review from donyunardi June 30, 2025 19:35
Copy link
Contributor

@donyunardi donyunardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It's consistent with the rest of the modules in this package.
Alternatively, user an also prepend the variable name with dot(.) to hide it from the teal_data.

Before you merge, can you please update NEWS to capture this update?

@kumamiao kumamiao merged commit dfb14b6 into main Jul 1, 2025
29 checks passed
@kumamiao kumamiao deleted the 304_wf_datanames branch July 1, 2025 19:48
@github-actions github-actions bot locked and limited conversation to collaborators Jul 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: values for datanames need to be updated in tm_g_waterfall module

3 participants