Skip to content

Conversation

@averissimo
Copy link
Contributor

@averissimo averissimo commented Sep 9, 2025

Pull Request

Changes description

  • Shows grob and gg objects in previewer with the same size as it's being shown in the module output.

@averissimo averissimo added the core label Sep 9, 2025
@averissimo averissimo requested a review from m7pr September 9, 2025 09:29
@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2025

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  ---------------------------------------------------------------
R/add_card.R                    125       3  97.60%   136, 177, 184
R/download.R                    188      15  92.02%   81-87, 138, 184-185, 250-254
R/editor_block.R                 28      28  0.00%    4-103
R/editor_card.R                  43      43  0.00%    2-52
R/LoadReporterModule.R          107      25  76.64%   100-105, 108-113, 119-124, 136-142
R/previewer_card_actions.R      104     104  0.00%    2-117
R/previewer_card.R               39      39  0.00%    2-46
R/previewer_content.R            53       8  84.91%   29-30, 32-33, 48, 60, 64, 68
R/previewer_deprecated.R         78       1  98.72%   113
R/previewer_report.R             77      77  0.00%    20-112
R/render.R                       32       0  100.00%
R/ReportCard.R                   57      13  77.19%   43, 122-123, 178-221, 239
R/Reporter.R                    174      28  83.91%   127-132, 156, 210, 318-327, 363-364, 369-374, 433-436, 443, 493
R/ResetModule.R                  55       0  100.00%
R/SimpleReporter.R               30       0  100.00%
R/teal_card.R                   148       3  97.97%   370-372
R/teal_report-c.R                 5       0  100.00%
R/teal_report-class.R            26       2  92.31%   50, 96
R/teal_report-eval_code.R         6       1  83.33%   27
R/teal_report-extract.R           3       3  0.00%    3-5
R/to_rmd.R                       85      28  67.06%   60, 75-90, 128-136, 161, 223
R/toHTML.R                       39      23  41.03%   25-37, 55, 79-96, 111-147
R/utils.R                       125      46  63.20%   24-47, 75, 84, 103-111, 148-157, 218-219
R/yaml_utils.R                   81       2  97.53%   78, 287
R/zzz.R                          29      28  3.45%    2-32, 37-39
TOTAL                          1737     520  70.06%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  -------
R/toHTML.R       +2      +2  -2.22%
TOTAL            +2      +2  -0.08%

Results for commit: 82b8152

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2025

Unit Tests Summary

  1 files   17 suites   1m 59s ⏱️
195 tests 193 ✅ 2 💤 0 ❌
309 runs  307 ✅ 2 💤 0 ❌

Results for commit 82b8152.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2025

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
Reporter 💚 $99.93$ $-3.76$ $0$ $0$ $0$ $0$

Results for commit 155e729

♻️ This comment has been updated with latest results.

@averissimo averissimo enabled auto-merge (squash) September 9, 2025 09:51
@m7pr m7pr self-assigned this Sep 9, 2025
@averissimo averissimo merged commit 667fc6d into main Sep 9, 2025
28 of 29 checks passed
@averissimo averissimo deleted the fix_dimensions@main branch September 9, 2025 10:27
@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants