Skip to content

Conversation

@osenan
Copy link
Contributor

@osenan osenan commented Oct 24, 2025

Pull Request

Fixes #436

Added a package option that will control the size of the fileInput, which by default is 5 MB.
The option is a new teal.reporter option and by default is 10MB. With that modification we allow:

  1. Control for developers to decide if they allow big reports to be uploaded.
  2. Unblock the possibility of having reports larger than 5MB.

Questions

  • This implementation will modify all allowed max sizes of shiny fileInputs. Is this a problem?
  • Do I need to document this option? I do not see specific documentation of other teal.reporter package options in vignettes or other parts.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2025


🎉 Thank you for your contribution! Before this PR can be accepted, we require that you all read and agree to our Contributor License Agreement.
You can digitally sign the CLA by posting a comment on this Pull Request in the format shown below. This agreement will apply to this PR as well as all future contributions on this repository.


I have read the CLA Document and I hereby sign the CLA


1 out of 2 committers have signed the CLA.
✅ (m7pr)[https://github.com/m7pr]
@osenan
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2025

Unit Tests Summary

  1 files   25 suites   2m 2s ⏱️
235 tests 229 ✅ 6 💤 0 ❌
369 runs  363 ✅ 6 💤 0 ❌

Results for commit 2909a46.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2025

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  --------------------------------------------------
R/add_card.R                    130      10  92.31%   47-54, 143, 184
R/download.R                    185      22  88.11%   27-33, 86-92, 143, 189-190, 255-259
R/editor_block.R                 28      15  46.43%   81-96
R/editor_card.R                  43      15  65.12%   2-15, 24
R/LoadReporterModule.R          110      32  70.91%   20-26, 105-110, 113-118, 124-129, 141-147
R/previewer_card_actions.R      115      17  85.22%   80-83, 94, 105-113, 117-118, 123
R/previewer_card.R               39      24  38.46%   2-27
R/previewer_content.R            52      23  55.77%   5-19, 28-29, 31-32, 47, 59, 63, 67
R/previewer_deprecated.R         78      33  57.69%   38-71, 113
R/previewer_report.R             80      26  67.50%   20-32, 94-108
R/render.R                       32       0  100.00%
R/ReportCard.R                   63      13  79.37%   51, 130-131, 186-229, 247
R/Reporter.R                    175      21  88.00%   128, 156, 211, 319-328, 364-365, 370-375, 444, 494
R/ResetModule.R                  56       8  85.71%   20-27
R/SimpleReporter.R               30      15  50.00%   39-53
R/teal_card.R                   157       3  98.09%   428-430
R/teal_report-c.R                 5       0  100.00%
R/teal_report-class.R            26       2  92.31%   50, 131
R/teal_report-eval_code.R         6       1  83.33%   27
R/teal_report-extract.R           3       0  100.00%
R/to_rmd.R                       86      30  65.12%   13, 67, 82-97, 128-136, 161, 223-229
R/toHTML.R                       48       5  89.58%   158, 230-264
R/utils.R                        96      28  70.83%   25, 34, 127-152
R/yaml_utils.R                   81       2  97.53%   78, 287
R/zzz.R                          30       1  96.67%   30
TOTAL                          1754     346  80.27%

Diff against main

Filename                  Stmts    Miss  Cover
----------------------  -------  ------  -------
R/LoadReporterModule.R       +2       0  +0.54%
R/zzz.R                      +1       0  +0.11%
TOTAL                        +3       0  +0.03%

Results for commit: eb2a7c4

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2025

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
Reporter 💔 $95.02$ $+2.01$ $0$ $0$ $0$ $0$

Results for commit 4f9418d

♻️ This comment has been updated with latest results.

@m7pr m7pr enabled auto-merge (squash) October 28, 2025 12:46
@m7pr m7pr assigned m7pr and unassigned osenan Oct 28, 2025
@m7pr m7pr merged commit 6f256e2 into main Oct 28, 2025
23 of 25 checks passed
@m7pr m7pr deleted the 436_allow_for_upload_larger_5MB@main branch October 28, 2025 12:55
@github-actions github-actions bot locked and limited conversation to collaborators Oct 28, 2025
@osenan
Copy link
Contributor Author

osenan commented Oct 28, 2025

I have read the CLA Document and I hereby sign the CLA

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Modify the way reports are uploaded so teal.reporter can handle reports larger than 5MB

3 participants