-
-
Notifications
You must be signed in to change notification settings - Fork 10
Add keyboard support to download modal for faster report downloads #438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
3
commits into
main
Choose a base branch
from
copilot/enhance-keyboard-download-modal
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+34
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: m7pr <[email protected]>
Co-authored-by: m7pr <[email protected]>
Copilot
AI
changed the title
[WIP] Improve keyboard accessibility for report downloading
Add keyboard support to download modal for faster report downloads
Oct 24, 2025
Copilot finished work on behalf of
m7pr
October 24, 2025 12:16
Code Coverage SummaryDiff against mainResults for commit: 4cf549b Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 25 suites 2m 0s ⏱️ Results for commit 4cf549b. ♻️ This comment has been updated with latest results. |
Unit Test Performance Difference
Results for commit 12edbf4 ♻️ This comment has been updated with latest results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR enhances the keyboard accessibility of the download modal, allowing users to press Enter from any input field to trigger the download action. This improvement makes it significantly faster to download multiple reports consecutively, as requested in #[issue_number].
Problem
Previously, users had to:
This workflow was inefficient when downloading multiple reports one after another, as the cursor position was already in the form fields but pressing Enter had no effect.
Solution
Implemented a new JavaScript function
enterToSubmitModalthat:This follows the same pattern already used in the add card modal (
enterToSubmit), but extends it to work with all form inputs rather than a single specific field.Changes
inst/js/extendShinyJs.js: Added newenterToSubmitModalfunction for modal-wide Enter key handlingR/download.R: Integrated the new function into the download modalNEWS.md: Documented the enhancementTesting
✅ JavaScript syntax validated with Node.js
✅ CodeQL security scan passed with no issues
✅ Follows existing code patterns and conventions
Benefits
Original prompt
Fixes #434
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.