Final UI/UX changes

[vedhav]

Companion of insightsengineering/teal#1571

Example app for testing

library(shiny)
devtools::load_all("../teal.widgets")

ui <- bslib::page_fluid(
  actionButton("wait", "Wait for 2 seconds `Sys.sleep(2)`"),
  verbatim_popup_ui("button_popup", button_label = "Button popup"),
  verbatim_popup_ui("link_popup", button_label = "Link popup", type = "link")
)
srv <- function(input, output) {
  observeEvent(input$wait, {
    Sys.sleep(2)
  })
  verbatim_popup_srv(
    "button_popup",
    "if (TRUE) { print('Popups are the best') }",
    title = "My custom title",
    style = TRUE
  )
  verbatim_popup_srv(
    "link_popup",
    "if (TRUE) { print('Popups are the best') }",
    title = "My custom title",
    style = TRUE
  )
}

shinyApp(ui, srv)

[github-actions]

Unit Tests Summary

  1 files   16 suites   1m 51s ⏱️
124 tests 124 ✅ 0 💤 0 ❌
333 runs  333 ✅ 0 💤 0 ❌

Results for commit 8327231.

♻️ This comment has been updated with latest results.

[github-actions]

Unit Test Performance Difference

Additional test case details

Test Suite	$Status$	Time on main	$±Time$	Test Case
verbatim_popup	👶		$+0.01$	verbatim_popup_ui_with_type_link_produces_a_button_with_a_class_link
verbatim_popup	💀	$0.01$	$-0.01$	verbatim_popup_ui_with_type_link_produces_a_link

Results for commit 8445e8b

♻️ This comment has been updated with latest results.

[github-actions]

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  --------------------------------------------------
R/basic_table_args.R             23       0  100.00%
R/draggable_buckets.R            87      87  0.00%    4-163
R/get_dt_rows.R                  13      13  0.00%    44-56
R/ggplot2_args.R                 49       0  100.00%
R/nested_closeable_modal.R       16      16  0.00%    83-98
R/optionalInput.R               255     212  16.86%   140-438, 501, 562, 568, 583-596
R/panel_group.R                  39      39  0.00%    50-136
R/plot_with_settings.R          309      16  94.82%   299-305, 327, 364, 373-374, 390, 578-579, 581, 583
R/standard_layout.R              52      20  61.54%   81-99, 106
R/table_with_settings.R         158       1  99.37%   100
R/utils.R                         7       0  100.00%
R/verbatim_popup.R              105      52  50.48%   72-87, 113-114, 116, 124-155, 176
R/white_small_well.R              7       7  0.00%    19-25
TOTAL                          1120     463  58.66%

Diff against main

Filename              Stmts    Miss  Cover
------------------  -------  ------  -------
R/verbatim_popup.R       -2       0  -0.93%
TOTAL                    -2       0  -0.07%

Results for commit: 8327231

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

[averissimo]

💯