Skip to content

Conversation

@averissimo
Copy link
Contributor

@averissimo averissimo commented Aug 1, 2025

Pull Request

Fixes #311

Changes description

  • Bumps shiny to v1.11.1 when the change was introduced
    • This is optional as it appears to work with previous versions, @vedhav any specific reason why it wasn't added in the previous PR?
  • Fixes behavior back to default (event -> deferred)
    • with event priority the trigger enters an infinite loop

Provide a new value of {priority: "event"} to always send now, even if the value hasn't changed.

Signed-off-by: André Veríssimo <[email protected]>
@averissimo averissimo added the core label Aug 1, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2025

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  --------------------------------------------------
R/basic_table_args.R             23       0  100.00%
R/draggable_buckets.R            87      87  0.00%    4-163
R/get_dt_rows.R                  13      13  0.00%    44-56
R/ggplot2_args.R                 49       0  100.00%
R/nested_closeable_modal.R       16      16  0.00%    83-98
R/optionalInput.R               255     212  16.86%   140-438, 501, 562, 568, 583-596
R/panel_group.R                  39      39  0.00%    50-136
R/plot_with_settings.R          309      16  94.82%   299-305, 327, 364, 373-374, 390, 578-579, 581, 583
R/standard_layout.R              52      20  61.54%   81-99, 106
R/table_with_settings.R         158       1  99.37%   100
R/utils.R                         7       0  100.00%
R/verbatim_popup.R              105      52  50.48%   72-87, 113-114, 116, 124-155, 176
R/white_small_well.R              7       7  0.00%    19-25
TOTAL                          1120     463  58.66%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 4db6400

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2025

Unit Tests Summary

  1 files   16 suites   1m 52s ⏱️
124 tests 124 ✅ 0 💤 0 ❌
333 runs  333 ✅ 0 💤 0 ❌

Results for commit 4db6400.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2025

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
draggable_buckets 💚 $8.59$ $-8.32$ $-2$ $+3$ $0$ $0$
get_dt_rows_ui 💚 $2.86$ $-2.84$ $-4$ $+1$ $0$ $0$
nested_closeable_modal_ui 💚 $2.79$ $-2.78$ $-5$ $+1$ $0$ $0$
optionalSelectInput_ui 💚 $2.87$ $-2.86$ $-14$ $+1$ $0$ $0$
optionalSliderInputValMinMax_ui 💚 $2.34$ $-2.32$ $-1$ $+1$ $0$ $0$
plot_with_settings_ui 💚 $49.34$ $-49.16$ $-30$ $+11$ $0$ $0$
table_with_settings_ui 💚 $32.76$ $-32.63$ $-47$ $+8$ $0$ $0$
verbatim_popup_ui 💚 $3.48$ $-3.46$ $-7$ $+1$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
draggable_buckets 💚 $2.42$ $-2.32$ e2e_teal.widgets_draggable_buckets_initializes_with_default_inputs
draggable_buckets 💚 $3.27$ $-3.15$ e2e_teal.widgets_draggable_buckets_initializes_without_input
draggable_buckets 💚 $2.91$ $-2.84$ e2e_teal.widgets_draggable_buckets_moving_elements_between_buckets_updates_input
get_dt_rows_ui 💚 $2.86$ $-2.83$ e2e_teal.widgets_get_dt_rows_rows_are_settable_and_visible
nested_closeable_modal_ui 💚 $2.79$ $-2.78$ e2e_teal.widgets_nested_closeable_modal_initializes
optionalSelectInput_ui 💚 $2.87$ $-2.86$ e2e_teal.widgets_optionalSelectInput_initializes
optionalSliderInputValMinMax_ui 💚 $2.34$ $-2.32$ e2e_teal.widgets_optionalSliderInputValMinMax_initializes
plot_with_settings_ui 💚 $4.22$ $-4.19$ e2e_teal.widgets_plot_with_settings_buttons_have_proper_FA_icons_and_two_of_them_are_dropdowns
plot_with_settings_ui 💚 $3.86$ $-3.84$ e2e_teal.widgets_plot_with_settings_clicking_download_download_button_downloads_image_in_a_specified_format
plot_with_settings_ui 💚 $4.74$ $-4.72$ e2e_teal.widgets_plot_with_settings_expanded_image_can_be_downloaded
plot_with_settings_ui 💚 $7.45$ $-7.44$ e2e_teal.widgets_plot_with_settings_expanded_image_can_be_resized
plot_with_settings_ui 💚 $3.12$ $-3.12$ e2e_teal.widgets_plot_with_settings_initializes_with_a_plot_and_the_settings_buttons
plot_with_settings_ui 💚 $3.30$ $-3.29$ e2e_teal.widgets_plot_with_settings_it_is_possible_to_set_height_and_width_for_the_plot_on_the_third_button_dropdown_menu_without_errors
plot_with_settings_ui 💚 $4.62$ $-4.61$ e2e_teal.widgets_plot_with_settings_main_image_can_be_resized
plot_with_settings_ui 💚 $5.07$ $-5.06$ e2e_teal.widgets_plot_with_settings_scrollbar_appears_when_image_is_resized
plot_with_settings_ui 💚 $4.22$ $-4.21$ e2e_teal.widgets_plot_with_settings_the_click_on_the_download_button_in_expand_modal_opens_a_download_dropdown
plot_with_settings_ui 💚 $4.28$ $-4.27$ e2e_teal.widgets_plot_with_settings_the_click_on_the_expand_button_opens_an_overlay_plot_height_plot_width_plot_download_dropdown_and_dismiss_button
plot_with_settings_ui 💚 $4.42$ $-4.40$ e2e_teal.widgets_plot_with_settings_the_click_on_the_resize_button_opens_a_dropdown_menu_plot_height_plot_width_plot_download_dropdown_and_dismiss_button
table_with_settings_ui 💚 $4.38$ $-4.36$ e2e_teal.widgets_table_with_settings_check_pagination_appearance_for_.txt_and_disappearance_for_.csv_for_the_first_button
table_with_settings_ui 💚 $4.23$ $-4.22$ e2e_teal.widgets_table_with_settings_check_pagination_appearance_for_.txt_and_disappearance_for_.csv_for_the_modal_on_the_second_button
table_with_settings_ui 💚 $4.07$ $-4.06$ e2e_teal.widgets_table_with_settings_clicking_download_download_button_downloads_table_in_a_specified_format
table_with_settings_ui 💚 $4.47$ $-4.46$ e2e_teal.widgets_table_with_settings_clicking_download_in_an_expand_modal_opens_dropdown_menu_with_dwnl_settings_such_as_file_type_file_name_pagination
table_with_settings_ui 💚 $4.38$ $-4.36$ e2e_teal.widgets_table_with_settings_expanded_table_can_be_downloaded
table_with_settings_ui 💚 $3.05$ $-3.04$ e2e_teal.widgets_table_with_settings_is_initialized_with_2_buttons_and_a_table
table_with_settings_ui 💚 $4.14$ $-4.13$ e2e_teal.widgets_table_with_settings_the_click_on_expand_button_opens_a_modal_with_a_table
table_with_settings_ui 💚 $4.03$ $-4.02$ e2e_teal.widgets_table_with_settings_the_click_on_the_download_button_opens_a_download_menu_with_file_type_file_name_and_download_button
verbatim_popup_ui 💚 $3.46$ $-3.46$ e2e_teal.widgets_verbatim_popup_is_initialized_with_a_button_that_opens_a_modal_with_a_verbatim_text

Results for commit 7979bac

♻️ This comment has been updated with latest results.

@averissimo averissimo marked this pull request as draft August 1, 2025 15:42
@averissimo
Copy link
Contributor Author

Here's working for both the minimal example and the tm_t_tte module in tmc

Screencast.From.2025-08-01.17-06-00.mp4

@averissimo averissimo marked this pull request as ready for review August 1, 2025 16:11
@vedhav vedhav self-assigned this Aug 4, 2025
Copy link
Contributor

@vedhav vedhav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for debugging and fixing it!

Co-authored-by: André Veríssimo <[email protected]>
Signed-off-by: Vedha Viyash <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: forrest_rsp, forrest_tte, km and tte modules are in a computing loop

3 participants