Skip to content

Conversation

@m7pr
Copy link
Contributor

@m7pr m7pr commented Jan 17, 2025

The same changes as in insightsengineering/teal.modules.general#826
We are unifying decorators and transformators default values for modules

@m7pr m7pr added the core label Jan 17, 2025
@m7pr m7pr requested a review from llrs-roche January 17, 2025 12:23
@github-actions
Copy link
Contributor

github-actions bot commented Jan 17, 2025

Unit Tests Summary

  1 files   28 suites   10m 27s ⏱️
276 tests 272 ✅ 4 💤 0 ❌
538 runs  534 ✅ 4 💤 0 ❌

Results for commit d6bf4f7.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 17, 2025

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
module_teal 💚 $128.60$ $-2.14$ $0$ $0$ $0$ $0$
shinytest2-module_bookmark_manager 💚 $37.07$ $-1.00$ $0$ $0$ $0$ $0$

Results for commit d77529e

♻️ This comment has been updated with latest results.

@llrs-roche llrs-roche self-assigned this Jan 17, 2025
Copy link
Contributor

@llrs-roche llrs-roche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one minor comment, the current documentation is specific for this example module. Could it be made a bit more general? See suggestion (not sure how if it would render well)

@m7pr m7pr enabled auto-merge (squash) January 17, 2025 14:48
@m7pr m7pr merged commit 32c6ef2 into main Jan 17, 2025
27 checks passed
@m7pr m7pr deleted the 1441_transformators@main branch January 17, 2025 15:40
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants