Skip to content

upversion r min version, and survial depednecies #1408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shajoezhu merged 3 commits into from
Mar 11, 2025
Merged

upversion r min version, and survial depednecies #1408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a8cefb3
upversion r min version, and survial depednecies
shajoezhu Mar 10, 2025
52034be
Merge branch 'main' into 1366_r4.4.0
edelarua Mar 10, 2025
37dffb1
Merge branch 'main' into 1366_r4.4.0
shajoezhu Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ URL: https://insightsengineering.github.io/tern/,
https://github.com/insightsengineering/tern/
BugReports: https://github.com/insightsengineering/tern/issues
Depends:
R (>= 3.6),
R (>= 4.4.0),
rtables (>= 0.6.11)
Imports:
broom (>= 0.5.4),
Expand All @@ -49,7 +49,7 @@ Imports:
rlang (>= 1.1.0),
scales (>= 1.2.0),
stats,
survival (>= 3.6-4),
survival (>= 3.8-3),
tibble (>= 2.0.0),
tidyr (>= 0.8.3),
utils
Expand Down
2 changes: 1 addition & 1 deletion tests/testthat/_snaps/coxph.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
Code
res
Output
[1] 1.0000000 1.0000000 0.9678110 0.3970066 0.3252267 0.5286392
[1] 1.0000000 0.7521316 0.3858022

---

Expand Down
4 changes: 0 additions & 4 deletions tests/testthat/test-coxph.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,6 @@ testthat::test_that("estimate_coef works correctly", {
})

testthat::test_that("try_car_anova works correctly", {
testthat::skip_if(packageVersion("survival") >= "3.8-3",
message = "Skip test is version is greater than 3.8-3, breaking change"
)

mod <- survival::coxph(
formula = survival::Surv(time = futime, event = fustat) ~ factor(rx) + survival::strata(ecog.ps),
data = survival::ovarian
Expand Down