(feat): add react strict mode and remove deprecated lifecycles methods #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Radu-Dunarentu
commented
Jun 13, 2018
Radu-Dunarentu
commented
- added react strict mode for demo
- removed the following deprecated lifecycle methods: componentWillMount, componentWillUpdate, componentDidUpdate
jquense
reviewed
Jun 13, 2018
| <div className="form-field"> | ||
| <label htmlFor="card">Card Number:</label> | ||
| <MaskedInput mask="1111 1111 1111 1111" name="card" id="card" size="20" value={this.state.card} onChange={this._onChange}/> | ||
| return (<React.StrictMode> |
Collaborator
There was a problem hiding this comment.
why add this? I think it'd better for the demo to not have an arbitrary performance block on it
Author
There was a problem hiding this comment.
I don't understand how StrictMode is a performance block, care to explain?
Edit: also, having StrictMode warns future developers for potential problems in the application.
Strict mode checks are run in development mode only; they do not impact the production build.
Author
|
any updates? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.