Add boot_disk_kms_key attribute for gke node pool#660
Open
thekogo wants to merge 1 commit intoinspec:mainfrom
Open
Add boot_disk_kms_key attribute for gke node pool#660thekogo wants to merge 1 commit intoinspec:mainfrom
thekogo wants to merge 1 commit intoinspec:mainfrom
Conversation
…node_pool documentation and implementation Signed-off-by: thekogo <thekogo@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change adds support for verifying the bootDiskKmsKey attribute in Google Kubernetes Engine (GKE) node pool configurations.
gcloud command:
gcloud container node-pools describe <node-pool> --cluster <cluster> --region <region> --format='value(config.bootDiskKmsKey')Please describe what this change achieves. Ensure you have read the Contributing to InSpec GCP document before
submitting.
Issues Resolved
Missing attribute coverage: Resolves the gap in node pool configuration verification by adding support for
bootDiskKmsKeyattributeList any existing issues this PR resolves, or any Discourse or StackOverflow discussion that's relevant.
Please ensure commits have been signed-off for the Developer Certificate of Origin. See https://github.com/chef/chef/blob/master/CONTRIBUTING.md#developer-certification-of-origin-dco