Do not run env check on lore import - only on cli invocation#173
Open
levkk wants to merge 1 commit intoinstacart:masterfrom
Open
Do not run env check on lore import - only on cli invocation#173levkk wants to merge 1 commit intoinstacart:masterfrom
levkk wants to merge 1 commit intoinstacart:masterfrom
Conversation
montanalow
suggested changes
Jan 5, 2021
Contributor
montanalow
left a comment
There was a problem hiding this comment.
One of the key value props is that lore guarantees the dependencies are correct across all the environments MLEs work in, from jupyter notebook investigations to training locally, at scale and during inference.
To use lore without that feature, you can:
import sys
sys.lore_no_env = True
import lore
It's not recommended, since it results in frequent production incidents as training/inference environments drift. Other dynamic languages like Ruby solve this problem with tools like Bundler. Since lore was created, PyPa has adopted Pipfile, but it has not become the standard complete replacement for pip, nor does it have the full functionality of Bundler. https://github.com/pypa/pipfile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
import loretriggers environment setup which prevents modular use of Lore. Run the env check explicitly instead whenloreentrypoint is called.Why
This allows Lore to be used as a module for its internal functions without the environment setup which can be done by other means, e.g. Docker.