Skip to content

Conversation

@lwalew
Copy link
Collaborator

@lwalew lwalew commented Dec 8, 2025

No description provided.

@lwalew lwalew requested a review from chrbrunk December 8, 2025 10:09
@github-actions
Copy link

github-actions bot commented Dec 8, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
src/mlipaudit
   __init__.py20100% 
   benchmark.py75790%138, 157, 223, 229–230, 240, 254
   exceptions.py20100% 
   io.py1002575%117, 121, 146–150, 152, 154, 171–172, 174–175, 192–193, 195, 213–221
   io_helpers.py520100% 
   run_mode.py50100% 
   scoring.py29775%101–102, 104, 107, 111–112, 114
src/mlipaudit/benchmarks
   __init__.py290100% 
src/mlipaudit/benchmarks/bond_length_distribution
   bond_length_distribution.py93396%201, 204, 269
src/mlipaudit/benchmarks/conformer_selection
   conformer_selection.py99594%194, 197, 237, 242, 282
src/mlipaudit/benchmarks/dihedral_scan
   dihedral_scan.py113595%211, 214, 248, 251, 293
src/mlipaudit/benchmarks/folding_stability
   folding_stability.py103496%201, 257, 262, 326
   helpers.py350100% 
src/mlipaudit/benchmarks/noncovalent_interactions
   noncovalent_interactions.py1641093%234, 237, 261, 272, 396, 411, 428, 512–514
src/mlipaudit/benchmarks/nudged_elastic_band
   engine.py1269425%62, 81–82, 84–89, 91, 93, 95–96, 98–99, 101–103, 112–113, 115–116, 120–121, 123, 130, 132, 134–136, 138–139, 141, 143–145, 147–151, 153, 159–163, 165–167, 169–171, 173–175, 177–180, 182, 185, 189–190, 192, 194–195, 197, 201–202, 205–210, 212–213, 229, 234, 236–238, 240, 242–243, 246–247, 253, 256–257, 261–262, 267
   nudged_elastic_band.py115694%278–279, 286, 298, 304, 311
src/mlipaudit/benchmarks/reactivity
   reactivity.py113397%227–228, 260
src/mlipaudit/benchmarks/reference_geometry_stability
   reference_geometry_stability.py120397%226, 298, 321
src/mlipaudit/benchmarks/ring_planarity
   ring_planarity.py97693%222, 225, 257, 260–261, 280
src/mlipaudit/benchmarks/sampling
   helpers.py64493%46, 67, 97, 129
   sampling.py2221095%292, 331, 372, 375–377, 427, 694, 812–813
src/mlipaudit/benchmarks/scaling
   scaling.py1003169%122–124, 132–133, 135–138, 148–150, 187–192, 195, 201–202, 204–205, 207–208, 211–212, 214, 235, 262, 275
src/mlipaudit/benchmarks/solvent_radial_distribution
   solvent_radial_distribution.py98891%183–184, 186, 225, 230–231, 296, 319
src/mlipaudit/benchmarks/stability
   stability.py1471887%147, 150, 182–183, 186–187, 189, 191, 194, 196, 412–413, 421, 457, 466, 501, 516, 527
src/mlipaudit/benchmarks/tautomers
   tautomers.py89594%171, 197, 200–201, 220
src/mlipaudit/benchmarks/water_radial_distribution
   water_radial_distribution.py91297%180, 260
src/mlipaudit/ui
   __init__.py160100% 
   bond_length_distribution.py581181%89–90, 95–96, 141–142, 147, 150, 176, 188, 192
   conformer_selection.py100793%133–134, 139–140, 195, 320, 324
   dihedral_scan.py1151289%141–142, 147–148, 259–260, 302, 313, 353, 355, 365, 369
   folding_stability.py96792%44, 226–227, 232–233, 406, 410
   leaderboard.py801087%67, 74, 78, 85, 287–289, 291, 293, 303
   noncovalent_interactions.py152994%205–206, 211–212, 392, 397, 432, 454, 458
   nudged_elastic_band.py553929%42–46, 50–51, 53, 66, 68, 75, 82, 89–90, 93, 97–99, 101, 103–105, 107–109, 111–113, 115, 117, 119, 121–122, 124, 135, 137, 149, 159, 163
   page_wrapper.py14285%36, 46
   reactivity.py59689%96–97, 102–103, 173, 177
   reference_geometry_stability.py66986%62, 131–132, 137–138, 199, 226, 236, 240
   ring_planarity.py56983%71–72, 77–78, 123–124, 160, 170, 174
   sampling.py87989%85, 129–130, 135–136, 166, 234, 265, 269
   scaling.py52688%135–136, 147–148, 162, 166
   solvent_radial_distribution.py832075%117–118, 123–124, 150, 156, 162–166, 168–169, 175, 178, 190, 197, 199, 211, 215
   stability.py601083%106–107, 112–113, 134–135, 138, 148, 177, 181
   tautomers.py62690%82–83, 88–89, 194, 198
   utils.py1061982%69, 73–74, 130, 192–195, 201, 251, 269–270, 273–274, 277, 287–289, 291
   water_radial_distribution.py98693%132–133, 138–139, 279, 283
src/mlipaudit/utils
   __init__.py40100% 
   inference.py27774%54–56, 65–66, 69, 72
   simulation.py52492%133, 171–173
   stability.py30583%60, 67, 91, 98, 102
   trajectory_helpers.py340100% 
   unallowed_elements.py100100% 
TOTAL385546987% 

Tests Skipped Failures Errors Time
118 0 💤 0 ❌ 0 🔥 10.988s ⏱️

Copy link
Collaborator

@chrbrunk chrbrunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, two questions:

  • Should we go directly into main here because it is kind of a "hotfix", or should we still go via develop intead?
  • Either way, could you please update the version number to 0.1.1 and update the Changelog 🙂 -- otherwise the CI will fail after merge

@lwalew lwalew changed the base branch from main to develop December 8, 2025 10:13
@lwalew lwalew requested a review from chrbrunk December 8, 2025 12:04
Copy link
Collaborator

@chrbrunk chrbrunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just check my final comment please, then we should be good to go.

@lwalew lwalew merged commit 62bf804 into develop Dec 8, 2025
7 checks passed
@lwalew lwalew deleted the fix/reactivity-ui-data-processing branch December 8, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants