feat: added support for mysql2 v3.11.5 #1467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryamohanan
force-pushed
the
currency-bot
branch
2 times, most recently
from
ef485da to
62635ca
Compare
Contributor
|
Skipped the Couchbase update from 4.4.3 to 4.4.4, as it is addressing in the PR #1466 |
aryamohanan
previously approved these changes
Dec 2, 2024
aryamohanan
changed the title
aryamohanan
force-pushed
the
currency-bot
branch
from
62635ca to
9f2dec5
Compare
abhilash-sivan
approved these changes
Dec 2, 2024
aryamohanan
force-pushed
the
currency-bot
branch
from
ece2006 to
08fb03c
Compare
aryamohanan
changed the title
aryamohanan
force-pushed
the
currency-bot
branch
from
08fb03c to
3b2d257
Compare
kirrg001
requested changes
Dec 3, 2024
Contributor
kirrg001
left a comment
kirrg001
left a comment
There was a problem hiding this comment.
Could you please add multi testing for "3.11.4" and "^3.11.5"?
aryamohanan
force-pushed
the
currency-bot
branch
from
3b2d257 to
eb1b1b6
Compare
kirrg001
approved these changes
Dec 3, 2024
Contributor
kirrg001
left a comment
kirrg001
left a comment
There was a problem hiding this comment.
One issue needs to be fixed. Otherwise pre-approve. LGTM!
Contributor
|
Please use:
feat(mysql2): added support for v3.11.5 or feat: added support for mysql2 v3.11.5 |
aryamohanan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In version 3.11.5 of the
mysql2library, some changes were introduced in the internal structure of the library. Specifically:queryandexecutemethods were moved toBaseConnectioninlib/base/connection.js.getConnection,query, andexecutemethods were relocated toBasePoolinlib/base/pool.js.Updated instrumentation logic to:
Connectionprototype derives fromBaseConnectionfor newer versions (v3.11.5+).Poolclass with changes to theBasePoolclass.ref INSTA-20850
reference PR sidorares/node-mysql2#3081